All of lore.kernel.org
 help / color / mirror / Atom feed
* [BUG] hid-multitouch ignores all event after recent patch in 3.17-rc1 to input_mt_sync_frame()
@ 2014-08-27  5:45 Reyad Attiyat
  2014-08-27  6:20 ` Henrik Rydberg
  0 siblings, 1 reply; 2+ messages in thread
From: Reyad Attiyat @ 2014-08-27  5:45 UTC (permalink / raw)
  To: rydberg, bleung, dmitry.torokhov, Benjamin Tissoires, linux-input

Hello Henrik Rydberg,

I noticed a recent patch to input-mt.c breaks hid-multitouch on my MS Surface:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/input/input-mt.c?id=f8ec894945e7d205ce62be59e55e72c4304e4739

This device uses a special quirk in the hid-multitouch driver to
ignore duplicate input events. This quirk uses the inline function
input_mt_is_used() to determine if an input frame is a duplicate. In
the patch you remove the line, mt->frame++, from the function
input_mt_sync_frame(). This causes the is_used function to return true
as the frame number never increases.

What would be the best way to solve this, is it ok to simply re add that line?

Thank You,
Reyad Attiyat

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-27  6:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-27  5:45 [BUG] hid-multitouch ignores all event after recent patch in 3.17-rc1 to input_mt_sync_frame() Reyad Attiyat
2014-08-27  6:20 ` Henrik Rydberg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.