Re: [PATCH v14 1/6] mmc: omap_hsmmc: Enable SDIO interrupt

[Florian Vaussard <florian.vaussard@epfl.ch>]

Hi Andreas,

On 08/24/2014 07:46 PM, Andreas Fenkart wrote:
> Hi Florian
> 
> 2014-08-24 10:26 GMT+02:00 Florian Vaussard <florian.vaussard@epfl.ch>:
>> Hi Andreas,
>>
>> On 05/29/2014 10:28 AM, Andreas Fenkart wrote:
>>> There have been various patches floating around for enabling
>>> the SDIO IRQ for hsmmc, but none of them ever got merged.
>>>
>>
>> [...]
>>
>>> For now, only support SDIO interrupt if we are booted with
>>> a separate wake-irq configued via device tree. This is
>>> because omaps need the wake-irq for idle states, and some
>>> omaps need special quirks. And we don't want to add new
>>> legacy mux platform init code callbacks any longer as we
>>> are moving to DT based booting anyways.
>>>
>>> To use it, you need to specify the wake-irq using the
>>> interrupts-extended property.
>>>
>>
>> First, thanks a lot for your tenacity on this patchset, this was a long
>> needed feature. I enabled the SDIO interrupt, and got the throughput of
>> my 88W8686-based chip multiplied by 15. Nice! I just have an issue with
>> the wake-up path, and maybe you could help me.
>>
>> According to the DM3730 TRM, the MMC2 has the SWAKEUP path. So first I
>> tried to give the same wake-irq as the MMC's one, but
>> omap_hsmmc_configure_wake_irq() fails to request it, as they are not
>> IRQF_SHARED.
> 
> Why can't it be shared?
> 

I first tried

interrupts-extended = <&intc 86 &intc 86>;

but devm_request_irq() in omap_hsmmc_configure_wake_irq() fails.
But this is probably not the good approach, as Tony pointed out.

Regards,
Florian