From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] clocksource: sh_tmu: Document r8a7779 binding
Date: Wed, 27 Aug 2014 11:10:44 +0000 [thread overview]
Message-ID: <53FDBCB4.6090806@cogentembedded.com> (raw)
In-Reply-To: <1409115600-26192-4-git-send-email-horms+renesas@verge.net.au>
On 8/27/2014 9:00 AM, Simon Horman wrote:
> In general Renesas hardware is not documented to the extent
> where the relationship between IP blocks on different SoCs can be assumed
> although they may appear to operate the same way. Furthermore the
> documentation typically does not specify a version for individual
> IP blocks. For these reasons a convention of using the SoC name in place
> of a version and providing SoC-specific compat strings has been adopted.
> Although not universally liked this convention is used in the bindings
> for the drivers a number of drivers for Renesas hardware. The purpose
> of this patch is to update the Renesas R-Car Timer Unit (TMU)
> driver to follow this convention.
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> * I plan to follow up with a patch patch to use the new binding in the
> dtsi files for the r8a7779 SoC.
> ---
> Documentation/devicetree/bindings/timer/renesas,tmu.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.txt b/Documentation/devicetree/bindings/timer/renesas,tmu.txt
> index 425d0c5..712ddfa 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,tmu.txt
> +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.txt
> @@ -8,7 +8,9 @@ are independent. The TMU hardware supports up to three channels.
>
> Required Properties:
>
> - - compatible: must contain "renesas,tmu"
> + - compatible: must contain one of the following.
Likewise, the example has both.
> + - "renesas,tmu" generic TMU
> + - "renesas,tmu-r8a7779" R8A7779 TMU
>
> - reg: base address and length of the registers block for the timer module.
>
> @@ -27,7 +29,7 @@ Optional Properties:
> Example: R8A7779 (R-Car H1) TMU0 node
>
> tmu0: timer@ffd80000 {
> - compatible = "renesas,tmu";
> + compatible = "renesas,tmu-r8a7779", "renesas,tmu";
> reg = <0xffd80000 0x30>;
> interrupts = <0 32 IRQ_TYPE_LEVEL_HIGH>,
> <0 33 IRQ_TYPE_LEVEL_HIGH>,
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] clocksource: sh_tmu: Document r8a7779 binding
Date: Wed, 27 Aug 2014 15:10:44 +0400 [thread overview]
Message-ID: <53FDBCB4.6090806@cogentembedded.com> (raw)
In-Reply-To: <1409115600-26192-4-git-send-email-horms+renesas@verge.net.au>
On 8/27/2014 9:00 AM, Simon Horman wrote:
> In general Renesas hardware is not documented to the extent
> where the relationship between IP blocks on different SoCs can be assumed
> although they may appear to operate the same way. Furthermore the
> documentation typically does not specify a version for individual
> IP blocks. For these reasons a convention of using the SoC name in place
> of a version and providing SoC-specific compat strings has been adopted.
> Although not universally liked this convention is used in the bindings
> for the drivers a number of drivers for Renesas hardware. The purpose
> of this patch is to update the Renesas R-Car Timer Unit (TMU)
> driver to follow this convention.
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> * I plan to follow up with a patch patch to use the new binding in the
> dtsi files for the r8a7779 SoC.
> ---
> Documentation/devicetree/bindings/timer/renesas,tmu.txt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.txt b/Documentation/devicetree/bindings/timer/renesas,tmu.txt
> index 425d0c5..712ddfa 100644
> --- a/Documentation/devicetree/bindings/timer/renesas,tmu.txt
> +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.txt
> @@ -8,7 +8,9 @@ are independent. The TMU hardware supports up to three channels.
>
> Required Properties:
>
> - - compatible: must contain "renesas,tmu"
> + - compatible: must contain one of the following.
Likewise, the example has both.
> + - "renesas,tmu" generic TMU
> + - "renesas,tmu-r8a7779" R8A7779 TMU
>
> - reg: base address and length of the registers block for the timer module.
>
> @@ -27,7 +29,7 @@ Optional Properties:
> Example: R8A7779 (R-Car H1) TMU0 node
>
> tmu0: timer at ffd80000 {
> - compatible = "renesas,tmu";
> + compatible = "renesas,tmu-r8a7779", "renesas,tmu";
> reg = <0xffd80000 0x30>;
> interrupts = <0 32 IRQ_TYPE_LEVEL_HIGH>,
> <0 33 IRQ_TYPE_LEVEL_HIGH>,
WBR, Sergei
next prev parent reply other threads:[~2014-08-27 11:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 4:59 [PATCH 0/3] clocksource: Document Renesas SoC specific bindings Simon Horman
2014-08-27 4:59 ` Simon Horman
2014-08-27 4:59 ` [PATCH 1/3] clocksource: sh_cmt: Document " Simon Horman
2014-08-27 4:59 ` Simon Horman
2014-08-27 4:59 ` [PATCH 2/3] clocksource: sh_mtu2: Document r7s72100 binding Simon Horman
2014-08-27 4:59 ` Simon Horman
2014-08-27 11:09 ` Sergei Shtylyov
2014-08-27 11:09 ` Sergei Shtylyov
2014-09-03 1:03 ` Simon Horman
2014-09-03 1:03 ` Simon Horman
2014-08-27 5:00 ` [PATCH 3/3] clocksource: sh_tmu: Document r8a7779 binding Simon Horman
2014-08-27 5:00 ` Simon Horman
2014-08-27 11:10 ` Sergei Shtylyov [this message]
2014-08-27 11:10 ` Sergei Shtylyov
2014-09-03 1:04 ` Simon Horman
2014-09-03 1:04 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2014-09-09 2:40 [GIT PULL] Renesas ARM Based SoC Clocksource Updates for v3.18 Simon Horman
2014-09-09 2:40 ` [PATCH 3/3] clocksource: sh_tmu: Document r8a7779 binding Simon Horman
2014-09-09 2:40 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FDBCB4.6090806@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.