From: Tomasz Figa <t.figa@samsung.com>
To: Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
catalin.marinas@arm.com
Cc: naveenkrishna.ch@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
cpgs@samsung.com, Thomas Abraham <thomas.ab@samsung.com>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH 10/14] arm64: dts: add pinctrl support to EXYNOS7
Date: Wed, 27 Aug 2014 13:14:06 +0200 [thread overview]
Message-ID: <53FDBD7E.3050102@samsung.com> (raw)
In-Reply-To: <1409132660-1898-2-git-send-email-ch.naveen@samsung.com>
Hi Naveen,
Please see my comments inline.
On 27.08.2014 11:44, Naveen Krishna Chatradhi wrote:
> Add the required pin configuration support to EXYNOS7
[snip]
> +/ {
> + /* ALIVE block @10580000 */
> + pinctrl@10580000 {
This syntax repeating the whole hierarchy of nodes in every dts file is
considered obsolete in case of Exynos DT sources. Please switch to
reference-based one. Please see related files for Exynos5260 and 5800 as
examples.
[snip]
> + disp_teson: disp_teson {
> + samsung,pins = "gpg0-1";
> + samsung,pin-function = <2>;
> + };
> +
> + disp_tesoff: disp_tesoff {
> + samsung,pins = "gpg0-1";
> + samsung,pin-function = <0>;
This is not a special function, so I don't think it belongs to this file.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 10/14] arm64: dts: add pinctrl support to EXYNOS7
Date: Wed, 27 Aug 2014 13:14:06 +0200 [thread overview]
Message-ID: <53FDBD7E.3050102@samsung.com> (raw)
In-Reply-To: <1409132660-1898-2-git-send-email-ch.naveen@samsung.com>
Hi Naveen,
Please see my comments inline.
On 27.08.2014 11:44, Naveen Krishna Chatradhi wrote:
> Add the required pin configuration support to EXYNOS7
[snip]
> +/ {
> + /* ALIVE block @10580000 */
> + pinctrl at 10580000 {
This syntax repeating the whole hierarchy of nodes in every dts file is
considered obsolete in case of Exynos DT sources. Please switch to
reference-based one. Please see related files for Exynos5260 and 5800 as
examples.
[snip]
> + disp_teson: disp_teson {
> + samsung,pins = "gpg0-1";
> + samsung,pin-function = <2>;
> + };
> +
> + disp_tesoff: disp_tesoff {
> + samsung,pins = "gpg0-1";
> + samsung,pin-function = <0>;
This is not a special function, so I don't think it belongs to this file.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-08-27 11:14 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 9:44 [PATCH 00/14] Support 64bit Cortex A57 based Exynos7 SoC Naveen Krishna Chatradhi
2014-08-27 9:44 ` Naveen Krishna Chatradhi
2014-08-27 9:44 ` [PATCH 10/14] arm64: dts: add pinctrl support to EXYNOS7 Naveen Krishna Chatradhi
2014-08-27 9:44 ` Naveen Krishna Chatradhi
2014-08-27 11:14 ` Tomasz Figa [this message]
2014-08-27 11:14 ` Tomasz Figa
2014-08-29 5:46 ` Naveen Krishna Ch
2014-08-29 5:46 ` Naveen Krishna Ch
2014-08-27 9:44 ` [PATCH 11/14] arm64: dts: Add initial device tree support for EXYNOS7 Naveen Krishna Chatradhi
2014-08-27 9:44 ` Naveen Krishna Chatradhi
2014-08-27 10:42 ` Mark Rutland
2014-08-27 10:42 ` Mark Rutland
2014-08-27 14:54 ` Catalin Marinas
2014-08-27 14:54 ` Catalin Marinas
2014-09-03 7:48 ` Naveen Krishna Ch
2014-09-03 7:48 ` Naveen Krishna Ch
2014-08-27 11:30 ` Tomasz Figa
2014-08-27 11:30 ` Tomasz Figa
2014-09-03 7:55 ` Naveen Krishna Ch
2014-09-03 7:55 ` Naveen Krishna Ch
2014-08-28 3:56 ` Olof Johansson
2014-08-28 3:56 ` Olof Johansson
2014-08-28 8:35 ` Marc Zyngier
2014-08-28 8:35 ` Marc Zyngier
2014-08-28 9:48 ` Mark Rutland
2014-08-28 9:48 ` Mark Rutland
2014-08-28 16:28 ` Olof Johansson
2014-08-28 16:28 ` Olof Johansson
2014-08-28 17:03 ` Mark Rutland
2014-08-28 17:03 ` Mark Rutland
2014-08-28 17:19 ` Olof Johansson
2014-08-28 17:19 ` Olof Johansson
2014-08-28 17:39 ` Mark Rutland
2014-08-28 17:39 ` Mark Rutland
2014-08-28 17:47 ` Geert Uytterhoeven
2014-08-28 17:47 ` Geert Uytterhoeven
2014-08-28 18:17 ` Mark Rutland
2014-08-28 18:17 ` Mark Rutland
2014-08-28 17:54 ` Rob Herring
2014-08-28 17:54 ` Rob Herring
2014-08-28 22:23 ` Olof Johansson
2014-08-28 22:23 ` Olof Johansson
2014-08-28 23:30 ` Simon Horman
2014-08-28 23:30 ` Simon Horman
2014-08-28 17:27 ` Marc Zyngier
2014-08-28 17:27 ` Marc Zyngier
2014-08-28 17:30 ` Mark Rutland
2014-08-28 17:30 ` Mark Rutland
2014-08-28 17:37 ` Marc Zyngier
2014-08-28 17:37 ` Marc Zyngier
2014-08-28 17:45 ` Mark Rutland
2014-08-28 17:45 ` Mark Rutland
[not found] ` <53FF6668.4080502-5wv7dgnIgG8@public.gmane.org>
2014-08-28 17:33 ` Rob Herring
2014-08-28 17:33 ` Rob Herring
2014-08-28 17:43 ` Mark Rutland
2014-08-28 17:43 ` Mark Rutland
2014-09-03 8:05 ` Naveen Krishna Ch
2014-09-03 8:05 ` Naveen Krishna Ch
2014-08-27 9:44 ` [PATCH 12/14] arm64: dts: add Exynos7 based Espresso board dts file Naveen Krishna Chatradhi
2014-08-27 9:44 ` Naveen Krishna Chatradhi
2014-08-27 11:32 ` Tomasz Figa
2014-08-27 11:32 ` Tomasz Figa
2014-08-28 4:00 ` Olof Johansson
2014-08-28 4:00 ` Olof Johansson
2014-08-29 5:51 ` Naveen Krishna Ch
2014-08-29 5:51 ` Naveen Krishna Ch
2014-08-27 9:44 ` [PATCH 13/14] arm64: exynos7: Enable ARMv8 based Exynos7 (SoC) support Naveen Krishna Chatradhi
2014-08-27 9:44 ` Naveen Krishna Chatradhi
2014-08-27 11:09 ` Mark Rutland
2014-08-27 11:09 ` Mark Rutland
2014-08-27 14:50 ` Catalin Marinas
2014-08-27 14:50 ` Catalin Marinas
2014-08-28 4:05 ` Olof Johansson
2014-08-28 4:05 ` Olof Johansson
2014-09-03 8:14 ` Naveen Krishna Ch
2014-09-03 8:14 ` Naveen Krishna Ch
2014-08-27 11:34 ` [PATCH 00/14] Support 64bit Cortex A57 based Exynos7 SoC Tomasz Figa
2014-08-27 11:34 ` Tomasz Figa
2014-09-13 10:57 ` Tomasz Figa
2014-09-13 10:57 ` Tomasz Figa
2014-09-14 13:45 ` Thomas Abraham
2014-09-14 13:45 ` Thomas Abraham
2014-08-28 3:47 ` Olof Johansson
2014-08-28 3:47 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FDBD7E.3050102@samsung.com \
--to=t.figa@samsung.com \
--cc=catalin.marinas@arm.com \
--cc=ch.naveen@samsung.com \
--cc=cpgs@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=robh@kernel.org \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.