* [PATCH] ww-mutex: clarify help text for DEBUG_WW_MUTEX_SLOWPATH
@ 2014-08-27 15:19 ` Rob Clark
0 siblings, 0 replies; 4+ messages in thread
From: Rob Clark @ 2014-08-27 15:19 UTC (permalink / raw)
To: linux-kernel; +Cc: dri-devel
We really don't want distro's enabling this in their kernels. Try and
make that more clear.
Signed-off-by: Rob Clark <robdclark@gmail.com>
---
lib/Kconfig.debug | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 07c2832..1b233fc 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -892,6 +892,10 @@ config DEBUG_WW_MUTEX_SLOWPATH
the full mutex checks enabled with (CONFIG_PROVE_LOCKING) this
will test all possible w/w mutex interface abuse with the
exception of simply not acquiring all the required locks.
+ Note that this feature can introduce significant overhead, so
+ it really should not be enabled in a production or distro kernel,
+ even a debug kernel. If you are a driver writer, enable it. If
+ you are a distro, do not.
config DEBUG_LOCK_ALLOC
bool "Lock debugging: detect incorrect freeing of live locks"
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ww-mutex: clarify help text for DEBUG_WW_MUTEX_SLOWPATH
@ 2014-08-27 15:19 ` Rob Clark
0 siblings, 0 replies; 4+ messages in thread
From: Rob Clark @ 2014-08-27 15:19 UTC (permalink / raw)
To: linux-kernel; +Cc: maarten.lankhorst, Daniel Vetter, dri-devel, Rob Clark
We really don't want distro's enabling this in their kernels. Try and
make that more clear.
Signed-off-by: Rob Clark <robdclark@gmail.com>
---
lib/Kconfig.debug | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 07c2832..1b233fc 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -892,6 +892,10 @@ config DEBUG_WW_MUTEX_SLOWPATH
the full mutex checks enabled with (CONFIG_PROVE_LOCKING) this
will test all possible w/w mutex interface abuse with the
exception of simply not acquiring all the required locks.
+ Note that this feature can introduce significant overhead, so
+ it really should not be enabled in a production or distro kernel,
+ even a debug kernel. If you are a driver writer, enable it. If
+ you are a distro, do not.
config DEBUG_LOCK_ALLOC
bool "Lock debugging: detect incorrect freeing of live locks"
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ww-mutex: clarify help text for DEBUG_WW_MUTEX_SLOWPATH
2014-08-27 15:19 ` Rob Clark
@ 2014-08-27 15:27 ` Maarten Lankhorst
-1 siblings, 0 replies; 4+ messages in thread
From: Maarten Lankhorst @ 2014-08-27 15:27 UTC (permalink / raw)
To: Rob Clark, linux-kernel; +Cc: dri-devel
Acked-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
On 27-08-14 17:19, Rob Clark wrote:
> We really don't want distro's enabling this in their kernels. Try and
> make that more clear.
>
> Signed-off-by: Rob Clark <robdclark@gmail.com>
> ---
> lib/Kconfig.debug | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 07c2832..1b233fc 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -892,6 +892,10 @@ config DEBUG_WW_MUTEX_SLOWPATH
> the full mutex checks enabled with (CONFIG_PROVE_LOCKING) this
> will test all possible w/w mutex interface abuse with the
> exception of simply not acquiring all the required locks.
> + Note that this feature can introduce significant overhead, so
> + it really should not be enabled in a production or distro kernel,
> + even a debug kernel. If you are a driver writer, enable it. If
> + you are a distro, do not.
>
> config DEBUG_LOCK_ALLOC
> bool "Lock debugging: detect incorrect freeing of live locks"
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ww-mutex: clarify help text for DEBUG_WW_MUTEX_SLOWPATH
@ 2014-08-27 15:27 ` Maarten Lankhorst
0 siblings, 0 replies; 4+ messages in thread
From: Maarten Lankhorst @ 2014-08-27 15:27 UTC (permalink / raw)
To: Rob Clark, linux-kernel; +Cc: Daniel Vetter, dri-devel
Acked-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
On 27-08-14 17:19, Rob Clark wrote:
> We really don't want distro's enabling this in their kernels. Try and
> make that more clear.
>
> Signed-off-by: Rob Clark <robdclark@gmail.com>
> ---
> lib/Kconfig.debug | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 07c2832..1b233fc 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -892,6 +892,10 @@ config DEBUG_WW_MUTEX_SLOWPATH
> the full mutex checks enabled with (CONFIG_PROVE_LOCKING) this
> will test all possible w/w mutex interface abuse with the
> exception of simply not acquiring all the required locks.
> + Note that this feature can introduce significant overhead, so
> + it really should not be enabled in a production or distro kernel,
> + even a debug kernel. If you are a driver writer, enable it. If
> + you are a distro, do not.
>
> config DEBUG_LOCK_ALLOC
> bool "Lock debugging: detect incorrect freeing of live locks"
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-27 15:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-27 15:19 [PATCH] ww-mutex: clarify help text for DEBUG_WW_MUTEX_SLOWPATH Rob Clark
2014-08-27 15:19 ` Rob Clark
2014-08-27 15:27 ` Maarten Lankhorst
2014-08-27 15:27 ` Maarten Lankhorst
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.