Re: [PATCH RFC V8 4/5] xen, libxc: Request page fault injection via libxc

[Razvan Cojocaru <rcojocaru@bitdefender.com>]

On 08/27/2014 06:46 PM, Jan Beulich wrote:
>>>> On 27.08.14 at 16:01, <rcojocaru@bitdefender.com> wrote:
>> --- a/xen/include/asm-x86/hvm/domain.h
>> +++ b/xen/include/asm-x86/hvm/domain.h
>> @@ -142,6 +142,14 @@ struct hvm_domain {
>>       */
>>      uint64_t sync_tsc;
>>  
>> +    /* Memory introspection page fault injection data. */
>> +    struct {
>> +        uint64_t address_space;
>> +        uint64_t virtual_address;
>> +        uint32_t errcode;
>> +        bool_t valid;
>> +    } fault_info;
> 
> The naming of the field aside I continue to be unconvinced of the
> general usefulness of this when being domain rather than vCPU
> based.

Oh, I've renamed everything else but missed that one, sorry. I'll make
sure to rename it and look into a way of maybe making it VCPU-based.


Thanks,
Razvan Cojocaru