From: Eric Blake <eblake@redhat.com>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, weidong.huang@huawei.com, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qmp: using genneric string paring function for 'qom-set'
Date: Thu, 28 Aug 2014 05:14:31 -0600 [thread overview]
Message-ID: <53FF0F17.1000903@redhat.com> (raw)
In-Reply-To: <1409203145-5976-1-git-send-email-arei.gonglei@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 800 bytes --]
On 08/27/2014 11:19 PM, arei.gonglei@huawei.com wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
In the subject: s/genneric/generic/, s/paring/parsing/
> At present, 'qom-set' only can set string type property,
qom-set is typed as taking arbitrary JSON 9one of the few commands with
'gen':'no', which means it is completely type-unsafe, and can therefore
accept EVERY type, including JSON integers, not just strings).
> which will restrict this qmp command's function.
> Using genneric string paring function can handle different
Same typos here as in subject.
> types, such as int/bool/string etc.
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-08-28 11:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 5:19 [Qemu-devel] [PATCH] qmp: using genneric string paring function for 'qom-set' arei.gonglei
2014-08-28 11:05 ` Paolo Bonzini
2014-08-28 14:09 ` Gonglei (Arei)
2014-08-28 11:14 ` Eric Blake [this message]
2014-08-28 14:12 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FF0F17.1000903@redhat.com \
--to=eblake@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.