From: kever.yang@rock-chips.com (Kever Yang)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH] ARM: dts: make arch-timer always on in rk3288 soc
Date: Fri, 29 Aug 2014 08:35:16 +0800 [thread overview]
Message-ID: <53FFCAC4.7030702@rock-chips.com> (raw)
In-Reply-To: <20140828151121.GM14650@leverpostej>
Mark,
Thanks for your reply and advice.
On 08/28/2014 11:11 PM, Mark Rutland wrote:
> On Thu, Aug 28, 2014 at 10:17:58AM +0100, Mark Rutland wrote:
>> Hi Kever,
>>
>> On Thu, Aug 28, 2014 at 02:40:17AM +0100, Kever Yang wrote:
>>> We need use the hrtimer, which need the arch-timer to be 'always-on'
>> I asked a question on the last posting [1]. Can you please confirm
>> either way?
>>
>> Thanks,
>> Mark.
>>
>> [1] lists.infradead.org/pipermail/linux-arm-kernel/2014-August/282327.html
> To clarify: if there are low power states that the CPU can enter where
> we lose state, then this patch isn't correct.
rk3288 has low power state and may turn off the cpu power domain
which will lost any logic state in cpu.
>
> A more general approach would be to enable the broadcast hrtimer for
> arm, as has been done for arm64.
>
> See commit 5d1638acb9f6 (tick: Introduce hrtimer based broadcast) which
> introduced the broadcast hrtimer, and commit 9358d755bd5c (arm64:
> kernel: initialize broadcast hrtimer based clock event device) which
> added the requisite plumbing for arm64.
I'll going to implement this and send another patch.
Thanks.
-Kever
WARNING: multiple messages have this Message-ID (diff)
From: Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
Cc: "heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org"
<heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
"dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org"
<dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
"sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org"
<sonnyrao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
"addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org"
<addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
"cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org"
<cf-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
"xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org"
<xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
"wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org"
<wulf-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
"lyz-TNX95d0MmH7DzftRWevZcw@public.gmane.org"
<lyz-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
"hj-TNX95d0MmH7DzftRWevZcw@public.gmane.org"
<hj-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
"huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org"
<huangtao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org
Subject: Re: [RESEND PATCH] ARM: dts: make arch-timer always on in rk3288 soc
Date: Fri, 29 Aug 2014 08:35:16 +0800 [thread overview]
Message-ID: <53FFCAC4.7030702@rock-chips.com> (raw)
In-Reply-To: <20140828151121.GM14650@leverpostej>
Mark,
Thanks for your reply and advice.
On 08/28/2014 11:11 PM, Mark Rutland wrote:
> On Thu, Aug 28, 2014 at 10:17:58AM +0100, Mark Rutland wrote:
>> Hi Kever,
>>
>> On Thu, Aug 28, 2014 at 02:40:17AM +0100, Kever Yang wrote:
>>> We need use the hrtimer, which need the arch-timer to be 'always-on'
>> I asked a question on the last posting [1]. Can you please confirm
>> either way?
>>
>> Thanks,
>> Mark.
>>
>> [1] lists.infradead.org/pipermail/linux-arm-kernel/2014-August/282327.html
> To clarify: if there are low power states that the CPU can enter where
> we lose state, then this patch isn't correct.
rk3288 has low power state and may turn off the cpu power domain
which will lost any logic state in cpu.
>
> A more general approach would be to enable the broadcast hrtimer for
> arm, as has been done for arm64.
>
> See commit 5d1638acb9f6 (tick: Introduce hrtimer based broadcast) which
> introduced the broadcast hrtimer, and commit 9358d755bd5c (arm64:
> kernel: initialize broadcast hrtimer based clock event device) which
> added the requisite plumbing for arm64.
I'll going to implement this and send another patch.
Thanks.
-Kever
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Kever Yang <kever.yang@rock-chips.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: "heiko@sntech.de" <heiko@sntech.de>,
"dianders@chromium.org" <dianders@chromium.org>,
"sonnyrao@chromium.org" <sonnyrao@chromium.org>,
"addy.ke@rock-chips.com" <addy.ke@rock-chips.com>,
"cf@rock-chips.com" <cf@rock-chips.com>,
"xjq@rock-chips.com" <xjq@rock-chips.com>,
"wulf@rock-chips.com" <wulf@rock-chips.com>,
"lyz@rock-chips.com" <lyz@rock-chips.com>,
"hj@rock-chips.com" <hj@rock-chips.com>,
"huangtao@rock-chips.com" <huangtao@rock-chips.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <Pawel.Moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
lorenzo.pieralisi@arm.com
Subject: Re: [RESEND PATCH] ARM: dts: make arch-timer always on in rk3288 soc
Date: Fri, 29 Aug 2014 08:35:16 +0800 [thread overview]
Message-ID: <53FFCAC4.7030702@rock-chips.com> (raw)
In-Reply-To: <20140828151121.GM14650@leverpostej>
Mark,
Thanks for your reply and advice.
On 08/28/2014 11:11 PM, Mark Rutland wrote:
> On Thu, Aug 28, 2014 at 10:17:58AM +0100, Mark Rutland wrote:
>> Hi Kever,
>>
>> On Thu, Aug 28, 2014 at 02:40:17AM +0100, Kever Yang wrote:
>>> We need use the hrtimer, which need the arch-timer to be 'always-on'
>> I asked a question on the last posting [1]. Can you please confirm
>> either way?
>>
>> Thanks,
>> Mark.
>>
>> [1] lists.infradead.org/pipermail/linux-arm-kernel/2014-August/282327.html
> To clarify: if there are low power states that the CPU can enter where
> we lose state, then this patch isn't correct.
rk3288 has low power state and may turn off the cpu power domain
which will lost any logic state in cpu.
>
> A more general approach would be to enable the broadcast hrtimer for
> arm, as has been done for arm64.
>
> See commit 5d1638acb9f6 (tick: Introduce hrtimer based broadcast) which
> introduced the broadcast hrtimer, and commit 9358d755bd5c (arm64:
> kernel: initialize broadcast hrtimer based clock event device) which
> added the requisite plumbing for arm64.
I'll going to implement this and send another patch.
Thanks.
-Kever
next prev parent reply other threads:[~2014-08-29 0:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 1:40 [RESEND PATCH] ARM: dts: make arch-timer always on in rk3288 soc Kever Yang
2014-08-28 1:40 ` Kever Yang
2014-08-28 1:40 ` Kever Yang
2014-08-28 9:17 ` Mark Rutland
2014-08-28 9:17 ` Mark Rutland
2014-08-28 9:17 ` Mark Rutland
2014-08-28 15:11 ` Mark Rutland
2014-08-28 15:11 ` Mark Rutland
2014-08-28 15:11 ` Mark Rutland
2014-08-29 0:35 ` Kever Yang [this message]
2014-08-29 0:35 ` Kever Yang
2014-08-29 0:35 ` Kever Yang
2014-08-29 3:06 ` Huang Tao
2014-08-29 3:06 ` Huang Tao
2014-08-29 3:06 ` Huang Tao
2014-08-29 11:22 ` Mark Rutland
2014-08-29 11:22 ` Mark Rutland
2014-08-29 11:22 ` Mark Rutland
2014-08-29 11:44 ` Huang Tao
2014-08-29 11:44 ` Huang Tao
2014-08-29 11:44 ` Huang Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FFCAC4.7030702@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.