All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhangfei.gao@linaro.org (zhangfei)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/6] ARM: dts: hix5hd2: add wdg node
Date: Fri, 29 Aug 2014 16:12:54 +0800	[thread overview]
Message-ID: <54003606.5090407@linaro.org> (raw)
In-Reply-To: <20140828171228.GR14650@leverpostej>



On 08/29/2014 01:12 AM, Mark Rutland wrote:
> On Thu, Aug 28, 2014 at 10:21:43AM +0100, Dinh Nguyen wrote:
>>
>>
>> On 8/28/14, 12:34 AM, Zhangfei Gao wrote:
>>> Signed-off-by: Jiancheng Xue <xuejiancheng@huawei.com>
>>> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
>>> ---
>>>   arch/arm/boot/dts/hisi-x5hd2.dtsi |    9 +++++++++
>>>   1 file changed, 9 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi
>>> index 152f3ad..7b1cb53 100644
>>> --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi
>>> +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi
>>> @@ -365,6 +365,15 @@
>>>   				#interrupt-cells = <2>;
>>>   				status = "disabled";
>>>   			};
>>> +
>>> +			wdg0: wdg at a2c000 {
>>
>> A nit-pick here, but everybody else is using 'wdt' for a watchdog timer
>> node.

Sure?will change to
wdt0: watchdog at a2c000

>>
>>> +				compatible = "arm,sp805", "arm,primecell";
>>
>> I didn't see an entry for "arm,sp805" in Documentations, should there be
>> one?
>
> There probably should, yes. It looks like only the sp804 is documented.
>
> Pawel, it looks like you were the first sp805,sp810 dt user. Care to put
> together a couple of documents? ;)
>

Yes, that would be great,
Not find bindings for drivers/watchdog/sp805_wdt.c.

Thanks

WARNING: multiple messages have this Message-ID (diff)
From: zhangfei <zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Dinh Nguyen <dinh.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"haifeng.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
	<haifeng.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"jchxue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
	<jchxue-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org"
	<xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org>,
	Jiancheng Xue
	<xuejiancheng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	pawel.moll-5wv7dgnIgG8@public.gmane.org
Subject: Re: [PATCH v2 6/6] ARM: dts: hix5hd2: add wdg node
Date: Fri, 29 Aug 2014 16:12:54 +0800	[thread overview]
Message-ID: <54003606.5090407@linaro.org> (raw)
In-Reply-To: <20140828171228.GR14650@leverpostej>



On 08/29/2014 01:12 AM, Mark Rutland wrote:
> On Thu, Aug 28, 2014 at 10:21:43AM +0100, Dinh Nguyen wrote:
>>
>>
>> On 8/28/14, 12:34 AM, Zhangfei Gao wrote:
>>> Signed-off-by: Jiancheng Xue <xuejiancheng-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>>> Signed-off-by: Zhangfei Gao <zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>> ---
>>>   arch/arm/boot/dts/hisi-x5hd2.dtsi |    9 +++++++++
>>>   1 file changed, 9 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/hisi-x5hd2.dtsi b/arch/arm/boot/dts/hisi-x5hd2.dtsi
>>> index 152f3ad..7b1cb53 100644
>>> --- a/arch/arm/boot/dts/hisi-x5hd2.dtsi
>>> +++ b/arch/arm/boot/dts/hisi-x5hd2.dtsi
>>> @@ -365,6 +365,15 @@
>>>   				#interrupt-cells = <2>;
>>>   				status = "disabled";
>>>   			};
>>> +
>>> +			wdg0: wdg@a2c000 {
>>
>> A nit-pick here, but everybody else is using 'wdt' for a watchdog timer
>> node.

Sure,will change to
wdt0: watchdog@a2c000

>>
>>> +				compatible = "arm,sp805", "arm,primecell";
>>
>> I didn't see an entry for "arm,sp805" in Documentations, should there be
>> one?
>
> There probably should, yes. It looks like only the sp804 is documented.
>
> Pawel, it looks like you were the first sp805,sp810 dt user. Care to put
> together a couple of documents? ;)
>

Yes, that would be great,
Not find bindings for drivers/watchdog/sp805_wdt.c.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-08-29  8:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28  5:34 [PATCH v2 0/6] hix5hd2 add some nodes Zhangfei Gao
2014-08-28  5:34 ` Zhangfei Gao
2014-08-28  5:34 ` [PATCH v2 1/6] ARM: dts: hix5hd2: add gmac node Zhangfei Gao
2014-08-28  5:34   ` Zhangfei Gao
2014-08-28  5:34 ` [PATCH v2 2/6] ARM: dts: hix5hd2: add mmc node Zhangfei Gao
2014-08-28  5:34   ` Zhangfei Gao
2014-08-28  5:34 ` [PATCH v2 3/6] ARM: dts: hix5hd2: add usb node Zhangfei Gao
2014-08-28  5:34   ` Zhangfei Gao
2014-08-28  5:34 ` [PATCH v2 4/6] ARM: dts: hix5hd2: add sata node Zhangfei Gao
2014-08-28  5:34   ` Zhangfei Gao
2014-08-28  5:34 ` [PATCH v2 5/6] ARM: dts: hix5hd2: add gpio node Zhangfei Gao
2014-08-28  5:34   ` Zhangfei Gao
2014-08-28  5:34 ` [PATCH v2 6/6] ARM: dts: hix5hd2: add wdg node Zhangfei Gao
2014-08-28  5:34   ` Zhangfei Gao
2014-08-28  9:21   ` Dinh Nguyen
2014-08-28  9:21     ` Dinh Nguyen
2014-08-28 17:12     ` Mark Rutland
2014-08-28 17:12       ` Mark Rutland
2014-08-29  8:12       ` zhangfei [this message]
2014-08-29  8:12         ` zhangfei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54003606.5090407@linaro.org \
    --to=zhangfei.gao@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.