All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arend van Spriel <arend@broadcom.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2 2/2] ath10k: add testmode
Date: Fri, 29 Aug 2014 16:37:54 +0200	[thread overview]
Message-ID: <54009042.6070309@broadcom.com> (raw)
In-Reply-To: <87y4u7suhu.fsf@kamboji.qca.qualcomm.com>

On 08/29/14 08:03, Kalle Valo wrote:
> Arend van Spriel<arend@broadcom.com>  writes:
>
>> On 08/28/14 10:02, Kalle Valo wrote:
>>> Kalle Valo<kvalo@qca.qualcomm.com>   writes:
>>
>>> Johannes suggested to put this to a separate file as that way it's
>>> easier for the user space. In v3 I'm planning to create testmode_uapi.h
>>> for this.
>>
>> I suppose that file will/should end up in include/uapi/...
>
> I was thinking not to put this to the include directory. This is just a
> testmode interface used only by few people, not a proper driver
> interface.

I see. In that case I would avoid the term 'uapi'. I think it will 
impose certain expectations.

>> so wouldn't it be better to call it ath10k_testmode.h?
>
> We already have testmode.h so having ath10k_testmode.h in the same
> directory would be confusing. Would testmode_i.h be any better?

What does it contain? Looks like command and attribute definitions for 
your testmode support. Maybe testmode_defs.h? As long as it is not uapi.

Regards,
Arend

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Arend van Spriel <arend@broadcom.com>
To: Kalle Valo <kvalo@qca.qualcomm.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] ath10k: add testmode
Date: Fri, 29 Aug 2014 16:37:54 +0200	[thread overview]
Message-ID: <54009042.6070309@broadcom.com> (raw)
In-Reply-To: <87y4u7suhu.fsf@kamboji.qca.qualcomm.com>

On 08/29/14 08:03, Kalle Valo wrote:
> Arend van Spriel<arend@broadcom.com>  writes:
>
>> On 08/28/14 10:02, Kalle Valo wrote:
>>> Kalle Valo<kvalo@qca.qualcomm.com>   writes:
>>
>>> Johannes suggested to put this to a separate file as that way it's
>>> easier for the user space. In v3 I'm planning to create testmode_uapi.h
>>> for this.
>>
>> I suppose that file will/should end up in include/uapi/...
>
> I was thinking not to put this to the include directory. This is just a
> testmode interface used only by few people, not a proper driver
> interface.

I see. In that case I would avoid the term 'uapi'. I think it will 
impose certain expectations.

>> so wouldn't it be better to call it ath10k_testmode.h?
>
> We already have testmode.h so having ath10k_testmode.h in the same
> directory would be confusing. Would testmode_i.h be any better?

What does it contain? Looks like command and attribute definitions for 
your testmode support. Maybe testmode_defs.h? As long as it is not uapi.

Regards,
Arend

  reply	other threads:[~2014-08-29 14:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-28  7:30 [PATCH v2 0/2] ath10k: testmode support Kalle Valo
2014-08-28  7:30 ` Kalle Valo
2014-08-28  7:30 ` [PATCH v2 1/2] ath10k: make ath10k_wmi_cmd_send() public Kalle Valo
2014-08-28  7:30   ` Kalle Valo
2014-08-28  7:30 ` [PATCH v2 2/2] ath10k: add testmode Kalle Valo
2014-08-28  7:30   ` Kalle Valo
2014-08-28  8:02   ` Kalle Valo
2014-08-28  8:02     ` Kalle Valo
2014-08-28 10:05     ` Arend van Spriel
2014-08-28 10:05       ` Arend van Spriel
2014-08-29  6:03       ` Kalle Valo
2014-08-29  6:03         ` Kalle Valo
2014-08-29 14:37         ` Arend van Spriel [this message]
2014-08-29 14:37           ` Arend van Spriel
2014-08-28 10:35   ` Michal Kazior
2014-08-28 10:35     ` Michal Kazior
2014-08-29  6:54     ` Kalle Valo
2014-08-29  6:54       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54009042.6070309@broadcom.com \
    --to=arend@broadcom.com \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.