All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sasha.levin@oracle.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
	khlebnikov@openvz.org, riel@redhat.com, mgorman@suse.de,
	mhocko@suse.cz, hughd@google.com, vbabka@suse.cz,
	walken@google.com, minchan@kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 3/3] Convert a few VM_BUG_ON callers to VM_BUG_ON_VMA
Date: Fri, 29 Aug 2014 15:32:05 -0400	[thread overview]
Message-ID: <5400D535.9080002@oracle.com> (raw)
In-Reply-To: <20140829191719.GC12774@nhori.bos.redhat.com>

On 08/29/2014 03:17 PM, Naoya Horiguchi wrote:
>> -	VM_BUG_ON(!PageLocked(page));
>> > +	VM_BUG_ON_PAGE(!PageLocked(page), page);
> This is not the replacement with VM_BUG_ON_VMA(), but it's fine :)

Woops, I was on a spree and got this one as well.

Thanks for the review Naoya!


Thanks,
Sasha

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sasha.levin@oracle.com>
To: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Cc: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
	khlebnikov@openvz.org, riel@redhat.com, mgorman@suse.de,
	mhocko@suse.cz, hughd@google.com, vbabka@suse.cz,
	walken@google.com, minchan@kernel.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 3/3] Convert a few VM_BUG_ON callers to VM_BUG_ON_VMA
Date: Fri, 29 Aug 2014 15:32:05 -0400	[thread overview]
Message-ID: <5400D535.9080002@oracle.com> (raw)
In-Reply-To: <20140829191719.GC12774@nhori.bos.redhat.com>

On 08/29/2014 03:17 PM, Naoya Horiguchi wrote:
>> -	VM_BUG_ON(!PageLocked(page));
>> > +	VM_BUG_ON_PAGE(!PageLocked(page), page);
> This is not the replacement with VM_BUG_ON_VMA(), but it's fine :)

Woops, I was on a spree and got this one as well.

Thanks for the review Naoya!


Thanks,
Sasha

  reply	other threads:[~2014-08-29 19:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29 14:54 [PATCH 1/3] Introduce dump_vma Sasha Levin
2014-08-29 14:54 ` Sasha Levin
2014-08-29 14:54 ` [PATCH 2/3] Introduce VM_BUG_ON_VMA Sasha Levin
2014-08-29 14:54   ` Sasha Levin
2014-08-29 18:51   ` Naoya Horiguchi
2014-08-29 18:51     ` Naoya Horiguchi
2014-08-29 14:54 ` [PATCH 3/3] Convert a few VM_BUG_ON callers to VM_BUG_ON_VMA Sasha Levin
2014-08-29 14:54   ` Sasha Levin
2014-08-29 19:17   ` Naoya Horiguchi
2014-08-29 19:17     ` Naoya Horiguchi
2014-08-29 19:32     ` Sasha Levin [this message]
2014-08-29 19:32       ` Sasha Levin
2014-08-29 18:51 ` [PATCH 1/3] Introduce dump_vma Naoya Horiguchi
2014-08-29 18:51   ` Naoya Horiguchi
2014-08-29 19:37 ` Andrew Morton
2014-08-29 19:37   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5400D535.9080002@oracle.com \
    --to=sasha.levin@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=khlebnikov@openvz.org \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.cz \
    --cc=minchan@kernel.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=riel@redhat.com \
    --cc=vbabka@suse.cz \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.