Re: [PATCH RFC v2 06/12] tools/libxc: Allocate magic page for mem access on ARM

[Julien Grall <julien.grall@linaro.org>]

Hello Tamas,

On 27/08/14 10:06, Tamas K Lengyel wrote:
> Signed-off-by: Tamas K Lengyel <tklengyel@sec.in.tum.de>

Reviewed-by: Julien Grall <julien.grall@linaro.org>

Regards,

> ---
>   tools/libxc/xc_dom_arm.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/libxc/xc_dom_arm.c b/tools/libxc/xc_dom_arm.c
> index 9b31b1f..13e881e 100644
> --- a/tools/libxc/xc_dom_arm.c
> +++ b/tools/libxc/xc_dom_arm.c
> @@ -26,9 +26,10 @@
>   #include "xg_private.h"
>   #include "xc_dom.h"
>
> -#define NR_MAGIC_PAGES 2
> +#define NR_MAGIC_PAGES 3
>   #define CONSOLE_PFN_OFFSET 0
>   #define XENSTORE_PFN_OFFSET 1
> +#define MEMACCESS_PFN_OFFSET 2
>
>   #define LPAE_SHIFT 9
>
> @@ -87,10 +88,13 @@ static int alloc_magic_pages(struct xc_dom_image *dom)
>
>       xc_clear_domain_page(dom->xch, dom->guest_domid, dom->console_pfn);
>       xc_clear_domain_page(dom->xch, dom->guest_domid, dom->xenstore_pfn);
> +    xc_clear_domain_page(dom->xch, dom->guest_domid, base + MEMACCESS_PFN_OFFSET);
>       xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_CONSOLE_PFN,
>               dom->console_pfn);
>       xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_STORE_PFN,
>               dom->xenstore_pfn);
> +    xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_ACCESS_RING_PFN,
> +            base + MEMACCESS_PFN_OFFSET);
>       /* allocated by toolstack */
>       xc_hvm_param_set(dom->xch, dom->guest_domid, HVM_PARAM_CONSOLE_EVTCHN,
>               dom->console_evtchn);
>

-- 
Julien Grall