All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@linaro.org>
To: Tamas K Lengyel <tklengyel@sec.in.tum.de>, xen-devel@lists.xen.org
Cc: ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com,
	stefano.stabellini@citrix.com, andres@lagarcavilla.org,
	jbeulich@suse.com, dgdegra@tycho.nsa.gov
Subject: Re: [PATCH RFC v2 08/12] xen/arm: Add mem_event domctl and mem_access memop.
Date: Fri, 29 Aug 2014 16:57:02 -0400	[thread overview]
Message-ID: <5400E91E.20904@linaro.org> (raw)
In-Reply-To: <1409148400-14810-9-git-send-email-tklengyel@sec.in.tum.de>

Hello Tamas,

On 27/08/14 10:06, Tamas K Lengyel wrote:
> +    case XEN_DOMCTL_mem_event_op:
> +        ret = mem_event_domctl(d, &domctl->u.mem_event_op,
> +                               guest_handle_cast(u_domctl, void));
> +        copyback = 1;
> +    break;

The code for this domctl is exactly the same on x86. Therefore, I would 
move it in common/domctl.c.

Of course, you will have to protected with an #ifdef HAVE_MEMACCESS or 
whatever define used to know when mem event is supported for the platform.
> +
> +    case XENMEM_access_op:
> +        rc = mem_access_memop(op, guest_handle_cast(arg, xen_mem_access_op_t));
> +        break;

Same remark here.

-- 
Julien Grall

  reply	other threads:[~2014-08-29 20:57 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27 14:06 [PATCH RFC v2 00/12] Mem_event and mem_access for ARM Tamas K Lengyel
2014-08-27 14:06 ` [PATCH RFC v2 01/12] xen: Relocate mem_access and mem_event into common Tamas K Lengyel
2014-08-27 14:17   ` Julien Grall
2014-08-27 14:57     ` Tamas K Lengyel
2014-08-28 10:22   ` Tim Deegan
2014-08-27 14:06 ` [PATCH RFC v2 02/12] xen/mem_event: Clean out superflous white-spaces Tamas K Lengyel
2014-08-28 10:22   ` Tim Deegan
2014-08-27 14:06 ` [PATCH RFC v2 03/12] xen/mem_event: Relax error condition on debug builds Tamas K Lengyel
2014-08-27 16:39   ` Julien Grall
2014-08-27 17:00     ` Tamas K Lengyel
2014-08-27 17:02   ` Andres Lagar Cavilla
2014-08-27 21:26     ` Tamas K Lengyel
2014-08-28  6:36     ` Jan Beulich
2014-08-29  4:20       ` Andres Lagar Cavilla
2014-08-27 14:06 ` [PATCH RFC v2 04/12] xen/mem_event: Abstract architecture specific sanity checks Tamas K Lengyel
2014-08-27 15:19   ` Jan Beulich
2014-08-27 17:17     ` Tamas K Lengyel
2014-08-27 21:54       ` Tamas K Lengyel
2014-08-28  6:38         ` Jan Beulich
2014-08-28  8:40           ` Tamas K Lengyel
2014-08-28  8:46             ` Jan Beulich
2014-08-28  8:52               ` Tamas K Lengyel
2014-08-27 14:06 ` [PATCH RFC v2 05/12] xen/mem_access: Abstract architecture specific sanity check Tamas K Lengyel
2014-08-27 14:06 ` [PATCH RFC v2 06/12] tools/libxc: Allocate magic page for mem access on ARM Tamas K Lengyel
2014-08-29 20:43   ` Julien Grall
2014-09-04  0:12   ` Stefano Stabellini
2014-08-27 14:06 ` [PATCH RFC v2 07/12] xen/arm: p2m type definitions and changes Tamas K Lengyel
2014-08-27 14:06 ` [PATCH RFC v2 08/12] xen/arm: Add mem_event domctl and mem_access memop Tamas K Lengyel
2014-08-29 20:57   ` Julien Grall [this message]
2014-08-30  8:19     ` Tamas K Lengyel
2014-08-27 14:06 ` [PATCH RFC v2 09/12] xen/arm: Data abort exception (R/W) mem_events Tamas K Lengyel
2014-08-27 17:01   ` Julien Grall
2014-08-27 17:22     ` Tamas K Lengyel
2014-08-29 21:41   ` Julien Grall
2014-08-30  8:16     ` Tamas K Lengyel
2014-08-27 14:06 ` [PATCH RFC v2 10/12] xen/arm: Instruction prefetch abort (X) mem_event handling Tamas K Lengyel
2014-08-27 14:06 ` [PATCH RFC v2 11/12] xen/arm: Enable the compilation of mem_access and mem_event on ARM Tamas K Lengyel
2014-08-27 15:24   ` Jan Beulich
2014-08-27 17:12     ` Tamas K Lengyel
2014-08-28  6:39       ` Jan Beulich
2014-08-28  8:42         ` Tamas K Lengyel
2014-08-28  8:54           ` Jan Beulich
2014-08-28  9:00             ` Tamas K Lengyel
2014-08-27 17:05   ` Daniel De Graaf
2014-08-27 17:13     ` Tamas K Lengyel
2014-08-27 14:06 ` [PATCH RFC v2 12/12] tools/tests: Enable xen-access " Tamas K Lengyel
2014-08-27 15:46 ` [PATCH RFC v2 00/12] Mem_event and mem_access for ARM Andrii Tseglytskyi
2014-08-27 17:05   ` Tamas K Lengyel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5400E91E.20904@linaro.org \
    --to=julien.grall@linaro.org \
    --cc=andres@lagarcavilla.org \
    --cc=dgdegra@tycho.nsa.gov \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=stefano.stabellini@citrix.com \
    --cc=tim@xen.org \
    --cc=tklengyel@sec.in.tum.de \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.