All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: "john.liuli" <john.liuli@huawei.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] numa: fix qerror_report_err not free issue
Date: Sat, 30 Aug 2014 09:26:01 +0400	[thread overview]
Message-ID: <54016069.4070209@msgid.tls.msk.ru> (raw)
In-Reply-To: <1409369799-9028-1-git-send-email-john.liuli@huawei.com>

30.08.2014 07:36, john.liuli wrote:
> From: Li Liu <john.liuli@huawei.com>
> 
> All qerror_report_err returned none NULL pointers need to
> be freed, otherwise will cause memory leaking.
> 
> Although this place did not cause real memory leaking by exit,
> obviously it's not correct to use qerror_report_err
> without error_free it.

I don't thing there's any good reason to free resources like
this (freeing memory, closing files, etc) right before exit()
(esp. in error path).  The OS will do that for us in one go
much faster.

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: "john.liuli" <john.liuli@huawei.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] numa: fix qerror_report_err not free issue
Date: Sat, 30 Aug 2014 09:26:01 +0400	[thread overview]
Message-ID: <54016069.4070209@msgid.tls.msk.ru> (raw)
In-Reply-To: <1409369799-9028-1-git-send-email-john.liuli@huawei.com>

30.08.2014 07:36, john.liuli wrote:
> From: Li Liu <john.liuli@huawei.com>
> 
> All qerror_report_err returned none NULL pointers need to
> be freed, otherwise will cause memory leaking.
> 
> Although this place did not cause real memory leaking by exit,
> obviously it's not correct to use qerror_report_err
> without error_free it.

I don't thing there's any good reason to free resources like
this (freeing memory, closing files, etc) right before exit()
(esp. in error path).  The OS will do that for us in one go
much faster.

/mjt

  reply	other threads:[~2014-08-30  5:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-30  3:36 [Qemu-trivial] [PATCH] numa: fix qerror_report_err not free issue john.liuli
2014-08-30  3:36 ` [Qemu-devel] " john.liuli
2014-08-30  5:26 ` Michael Tokarev [this message]
2014-08-30  5:26   ` Michael Tokarev
2014-08-30  5:28   ` [Qemu-trivial] " Gonglei (Arei)
2014-08-30  5:28     ` Gonglei (Arei)
2014-08-30  6:24   ` [Qemu-trivial] " Li Liu
2014-08-30  6:24     ` [Qemu-devel] " Li Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54016069.4070209@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=john.liuli@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.