All of lore.kernel.org
 help / color / mirror / Atom feed
From: varkabhadram@gmail.com (Varka Bhadram)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/2] rc: Add DT bindings for hix5hd2
Date: Mon, 01 Sep 2014 09:19:03 +0530	[thread overview]
Message-ID: <5403ECAF.1040506@gmail.com> (raw)
In-Reply-To: <1409452751-17463-2-git-send-email-zhangfei.gao@linaro.org>

On 08/31/2014 08:09 AM, Zhangfei Gao wrote:
> From: Guoxiong Yan <yanguoxiong@huawei.com>
>
> Signed-off-by: Guoxiong Yan <yanguoxiong@huawei.com>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
>   .../devicetree/bindings/media/hix5hd2-ir.txt       |   25 ++++++++++++++++++++
>   1 file changed, 25 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/media/hix5hd2-ir.txt
>
> diff --git a/Documentation/devicetree/bindings/media/hix5hd2-ir.txt b/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
> new file mode 100644
> index 0000000..fb5e760
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
> @@ -0,0 +1,25 @@
> +Device-Tree bindings for hix5hd2 ir IP
> +
> +Required properties:
> +	- compatible: Should contain "hisilicon,hix5hd2-ir".
> +	- reg: Base physical address of the controller and length of memory
> +	  mapped region.
> +	- interrupts: interrupt-specifier for the sole interrupt generated by
> +	  the device. The interrupt specifier format depends on the interrupt
> +	  controller parent.
> +	- clocks: clock phandle and specifier pair.
> +	- hisilicon,power-syscon: phandle of syscon used to control power.
> +

No need of tab space before -compatible.... Give tab spaces after properties...

ex:
  
Required properties:
- compatible		: Should contain "hisilicon,hix5hd2-ir".
- reg			: Base physical address of the controller and length of memory
			  mapped region.

...

Its not standard, but in my view it is understandable. Now every one following this
one.

Thanks..

> +Optional properties:
> +	- linux,rc-map-name : Remote control map name.
> +
> +Example node:
> +
> +	ir: ir at f8001000 {
> +		compatible = "hisilicon,hix5hd2-ir";
> +		reg = <0xf8001000 0x1000>;
> +		interrupts = <0 47 4>;
> +		clocks = <&clock HIX5HD2_FIXED_24M>;
> +		hisilicon,power-syscon = <&sysctrl>;
> +		linux,rc-map-name = "rc-tivo";
> +	};


-- 
Regards,
Varka Bhadram.

WARNING: multiple messages have this Message-ID (diff)
From: Varka Bhadram <varkabhadram@gmail.com>
To: Zhangfei Gao <zhangfei.gao@linaro.org>,
	Mauro Carvalho Chehab <m.chehab@samsung.com>,
	sean@mess.org, arnd@arndb.de, haifeng.yan@linaro.org,
	jchxue@gmail.com
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-media@vger.kernel.org,
	Guoxiong Yan <yanguoxiong@huawei.com>
Subject: Re: [PATCH v4 1/2] rc: Add DT bindings for hix5hd2
Date: Mon, 01 Sep 2014 09:19:03 +0530	[thread overview]
Message-ID: <5403ECAF.1040506@gmail.com> (raw)
In-Reply-To: <1409452751-17463-2-git-send-email-zhangfei.gao@linaro.org>

On 08/31/2014 08:09 AM, Zhangfei Gao wrote:
> From: Guoxiong Yan <yanguoxiong@huawei.com>
>
> Signed-off-by: Guoxiong Yan <yanguoxiong@huawei.com>
> Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
>   .../devicetree/bindings/media/hix5hd2-ir.txt       |   25 ++++++++++++++++++++
>   1 file changed, 25 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/media/hix5hd2-ir.txt
>
> diff --git a/Documentation/devicetree/bindings/media/hix5hd2-ir.txt b/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
> new file mode 100644
> index 0000000..fb5e760
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/hix5hd2-ir.txt
> @@ -0,0 +1,25 @@
> +Device-Tree bindings for hix5hd2 ir IP
> +
> +Required properties:
> +	- compatible: Should contain "hisilicon,hix5hd2-ir".
> +	- reg: Base physical address of the controller and length of memory
> +	  mapped region.
> +	- interrupts: interrupt-specifier for the sole interrupt generated by
> +	  the device. The interrupt specifier format depends on the interrupt
> +	  controller parent.
> +	- clocks: clock phandle and specifier pair.
> +	- hisilicon,power-syscon: phandle of syscon used to control power.
> +

No need of tab space before -compatible.... Give tab spaces after properties...

ex:
  
Required properties:
- compatible		: Should contain "hisilicon,hix5hd2-ir".
- reg			: Base physical address of the controller and length of memory
			  mapped region.

...

Its not standard, but in my view it is understandable. Now every one following this
one.

Thanks..

> +Optional properties:
> +	- linux,rc-map-name : Remote control map name.
> +
> +Example node:
> +
> +	ir: ir@f8001000 {
> +		compatible = "hisilicon,hix5hd2-ir";
> +		reg = <0xf8001000 0x1000>;
> +		interrupts = <0 47 4>;
> +		clocks = <&clock HIX5HD2_FIXED_24M>;
> +		hisilicon,power-syscon = <&sysctrl>;
> +		linux,rc-map-name = "rc-tivo";
> +	};


-- 
Regards,
Varka Bhadram.

  reply	other threads:[~2014-09-01  3:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-31  2:39 [PATCH v4 0/3] Introduce hix5hd2 IR transmitter driver Zhangfei Gao
2014-08-31  2:39 ` Zhangfei Gao
2014-08-31  2:39 ` [PATCH v4 1/2] rc: Add DT bindings for hix5hd2 Zhangfei Gao
2014-08-31  2:39   ` Zhangfei Gao
2014-09-01  3:49   ` Varka Bhadram [this message]
2014-09-01  3:49     ` Varka Bhadram
2014-09-01  3:54     ` zhangfei
2014-09-01  3:54       ` zhangfei
2014-08-31  2:39 ` [PATCH v4 2/2] rc: Introduce hix5hd2 IR transmitter driver Zhangfei Gao
2014-08-31  2:39   ` Zhangfei Gao
2014-08-31  2:39 ` [PATCH v4 3/3] ARM: dts: hix5hd2: add ir node Zhangfei Gao
2014-08-31  2:39   ` Zhangfei Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5403ECAF.1040506@gmail.com \
    --to=varkabhadram@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.