From: Rob Jones <rob.jones@codethink.co.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
jbaron@akamai.com, cl@linux-foundation.org, penberg@kernel.org,
mpm@selenic.com, linux-kernel@codethink.co.uk
Subject: Re: [PATCH 0/4] Tidy up of modules using seq_open()
Date: Mon, 01 Sep 2014 13:47:10 +0100 [thread overview]
Message-ID: <54046ACE.2080701@codethink.co.uk> (raw)
In-Reply-To: <20140829121426.4044f2a330f9d74fe37f7825@linux-foundation.org>
On 29/08/14 20:14, Andrew Morton wrote:
> On Fri, 29 Aug 2014 17:06:36 +0100 Rob Jones <rob.jones@codethink.co.uk> wrote:
>
>> Many modules use seq_open() when seq_open_private() or
>> __seq_open_private() would be more appropriate and result in
>> simpler, cleaner code.
>>
>> This patch sequence changes those instances in IPC, MM and LIB.
>
> Looks good to me.
>
> I can't begin to imagine why we added the global, exported-to-modules
> seq_open_private() without bothering to document it, so any time you
> feel like adding the missing kerneldoc...
Already done, I waited for that to be accepted before I submitted this
patch :-)
>
> And psize should have been size_t, ho hum.
I'll fix that while I'm in the vicinity.
>
>
--
Rob Jones
Codethink Ltd
mailto:rob.jones@codethink.co.uk
tel:+44 161 236 5575
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Jones <rob.jones@codethink.co.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
jbaron@akamai.com, cl@linux-foundation.org, penberg@kernel.org,
mpm@selenic.com, linux-kernel@codethink.co.uk
Subject: Re: [PATCH 0/4] Tidy up of modules using seq_open()
Date: Mon, 01 Sep 2014 13:47:10 +0100 [thread overview]
Message-ID: <54046ACE.2080701@codethink.co.uk> (raw)
In-Reply-To: <20140829121426.4044f2a330f9d74fe37f7825@linux-foundation.org>
On 29/08/14 20:14, Andrew Morton wrote:
> On Fri, 29 Aug 2014 17:06:36 +0100 Rob Jones <rob.jones@codethink.co.uk> wrote:
>
>> Many modules use seq_open() when seq_open_private() or
>> __seq_open_private() would be more appropriate and result in
>> simpler, cleaner code.
>>
>> This patch sequence changes those instances in IPC, MM and LIB.
>
> Looks good to me.
>
> I can't begin to imagine why we added the global, exported-to-modules
> seq_open_private() without bothering to document it, so any time you
> feel like adding the missing kerneldoc...
Already done, I waited for that to be accepted before I submitted this
patch :-)
>
> And psize should have been size_t, ho hum.
I'll fix that while I'm in the vicinity.
>
>
--
Rob Jones
Codethink Ltd
mailto:rob.jones@codethink.co.uk
tel:+44 161 236 5575
next prev parent reply other threads:[~2014-09-01 12:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 16:06 [PATCH 0/4] Tidy up of modules using seq_open() Rob Jones
2014-08-29 16:06 ` Rob Jones
2014-08-29 16:06 ` [PATCH 1/4] ipc: Use __seq_open_private() instead of seq_open() Rob Jones
2014-08-29 16:06 ` Rob Jones
2014-08-29 16:06 ` [PATCH 2/4] mm: Use seq_open_private() " Rob Jones
2014-08-29 16:06 ` Rob Jones
2014-08-29 16:06 ` [PATCH 3/4] mm: Use __seq_open_private() " Rob Jones
2014-08-29 16:06 ` Rob Jones
2014-08-29 16:24 ` Christoph Lameter
2014-08-29 16:24 ` Christoph Lameter
2014-08-29 16:06 ` [PATCH 4/4] lib: Use seq_open_private() " Rob Jones
2014-08-29 16:06 ` Rob Jones
2014-08-29 19:18 ` Jason Baron
2014-08-29 19:18 ` Jason Baron
2014-08-29 19:14 ` [PATCH 0/4] Tidy up of modules using seq_open() Andrew Morton
2014-08-29 19:14 ` Andrew Morton
2014-09-01 12:47 ` Rob Jones [this message]
2014-09-01 12:47 ` Rob Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54046ACE.2080701@codethink.co.uk \
--to=rob.jones@codethink.co.uk \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=jbaron@akamai.com \
--cc=linux-kernel@codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.