All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <info@lategoodbye.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawn.guo@linaro.org>,
	Fabio Estevam <fabio.estevam@freescale.com>,
	"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Otavio Salvador <otavio@ossystems.com.br>
Subject: Re: ARM: mx28: cpufreq-cpu0 support?
Date: Tue, 02 Sep 2014 07:09:42 +0200	[thread overview]
Message-ID: <54055116.4030608@lategoodbye.de> (raw)
In-Reply-To: <CAOMZO5A7-66LJtv4O2TghN3gVzme4N6JFMYd8TV7zXhUhsXedQ@mail.gmail.com>

Hello Fabio,

Am 01.09.2014 15:33, schrieb Fabio Estevam:
> Hi Stefan,
>
> On Mon, Sep 1, 2014 at 3:31 AM, Stefan Wahren <info@lategoodbye.de> wrote:
>
>> thanks. Okay, that leads to more questions:
>>
>> How can i test a ported mxs-regulator driver, that it's really working? Is
>> there any userspace interface?
>
> After you ported the mxs regulator you can check whether it probed
> correctly and if the reported voltages in the kernel log match the
> register settings. You can also check if the voltages are really in
> the correct reported value with a scope.
>
> On mx6q we have the following:
>
> [    0.070554] vdd1p1: 800 <--> 1375 mV at 1100 mV
> [    0.071521] vdd3p0: 2800 <--> 3150 mV at 3000 mV
> [    0.072397] vdd2p5: 2000 <--> 2750 mV at 2400 mV
> [    0.073369] vddarm: 725 <--> 1450 mV at 1150 mV
> [    0.074282] vddpu: 725 <--> 1450 mV at 1150 mV
> [    0.075247] vddsoc: 725 <--> 1450 mV at 1200 mV
>
> and you should get something like that in your kernel log after you
> ported the mxs regulator driver.
>
>> Is there a good DT implementation of a similiar regulator driver, so i can
>> orientate on?
>
> You could take a look at the drivers/regulator/anatop-regulator.c
> driver, which handles the internal regulators on mx6.
>
> The dts is arch/arm/boot/dts/imx6qdl.dtsi . Search for "anatop-regulator"
>

thanks again. Now i unterstand much more, but otherwise the portation 
won't be straight forward. The old source in 
drivers/regulator/mxs-regulator.c needs a low level part located in 
arch/arm/plat-mx28/power.c . As far as i know, the low level part needs 
to move into the devicetree binding and into the mxs-regulator.c . Am i 
right?

Yesterday i had looked into the mx28 reference manual and into the low 
level part of the mxs regulator. The reference manual defines four 
voltage regulators: vddd, vdda, vddio and vddmem plus a overall current 
regulator. But the low level part make use of vddd, vdda, vddio, 
vddio_bo and the overall current.

Do i need the brown out regulator (vddio_bo) and the vddmem?

Stefan


WARNING: multiple messages have this Message-ID (diff)
From: info@lategoodbye.de (Stefan Wahren)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM: mx28: cpufreq-cpu0 support?
Date: Tue, 02 Sep 2014 07:09:42 +0200	[thread overview]
Message-ID: <54055116.4030608@lategoodbye.de> (raw)
In-Reply-To: <CAOMZO5A7-66LJtv4O2TghN3gVzme4N6JFMYd8TV7zXhUhsXedQ@mail.gmail.com>

Hello Fabio,

Am 01.09.2014 15:33, schrieb Fabio Estevam:
> Hi Stefan,
>
> On Mon, Sep 1, 2014 at 3:31 AM, Stefan Wahren <info@lategoodbye.de> wrote:
>
>> thanks. Okay, that leads to more questions:
>>
>> How can i test a ported mxs-regulator driver, that it's really working? Is
>> there any userspace interface?
>
> After you ported the mxs regulator you can check whether it probed
> correctly and if the reported voltages in the kernel log match the
> register settings. You can also check if the voltages are really in
> the correct reported value with a scope.
>
> On mx6q we have the following:
>
> [    0.070554] vdd1p1: 800 <--> 1375 mV at 1100 mV
> [    0.071521] vdd3p0: 2800 <--> 3150 mV at 3000 mV
> [    0.072397] vdd2p5: 2000 <--> 2750 mV at 2400 mV
> [    0.073369] vddarm: 725 <--> 1450 mV at 1150 mV
> [    0.074282] vddpu: 725 <--> 1450 mV at 1150 mV
> [    0.075247] vddsoc: 725 <--> 1450 mV at 1200 mV
>
> and you should get something like that in your kernel log after you
> ported the mxs regulator driver.
>
>> Is there a good DT implementation of a similiar regulator driver, so i can
>> orientate on?
>
> You could take a look at the drivers/regulator/anatop-regulator.c
> driver, which handles the internal regulators on mx6.
>
> The dts is arch/arm/boot/dts/imx6qdl.dtsi . Search for "anatop-regulator"
>

thanks again. Now i unterstand much more, but otherwise the portation 
won't be straight forward. The old source in 
drivers/regulator/mxs-regulator.c needs a low level part located in 
arch/arm/plat-mx28/power.c . As far as i know, the low level part needs 
to move into the devicetree binding and into the mxs-regulator.c . Am i 
right?

Yesterday i had looked into the mx28 reference manual and into the low 
level part of the mxs regulator. The reference manual defines four 
voltage regulators: vddd, vdda, vddio and vddmem plus a overall current 
regulator. But the low level part make use of vddd, vdda, vddio, 
vddio_bo and the overall current.

Do i need the brown out regulator (vddio_bo) and the vddmem?

Stefan

  reply	other threads:[~2014-09-02  5:09 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-24  9:47 ARM: mx28: cpufreq-cpu0 support? Stefan Wahren
2014-08-24  9:47 ` Stefan Wahren
2014-08-25  8:01 ` Shawn Guo
2014-08-25  8:01   ` Shawn Guo
2014-08-25 10:30   ` Stefan Wahren
2014-08-25 10:30     ` Stefan Wahren
2014-08-30 17:05     ` Fabio Estevam
2014-08-30 17:05       ` Fabio Estevam
2014-08-30 17:07       ` Fabio Estevam
2014-08-30 17:07         ` Fabio Estevam
2014-09-01  6:31         ` Stefan Wahren
2014-09-01  6:31           ` Stefan Wahren
2014-09-01 13:33           ` Fabio Estevam
2014-09-01 13:33             ` Fabio Estevam
2014-09-02  5:09             ` Stefan Wahren [this message]
2014-09-02  5:09               ` Stefan Wahren
2014-09-02 13:13               ` Fabio Estevam
2014-09-02 13:13                 ` Fabio Estevam
2014-09-22 21:25             ` Stefan Wahren
2014-09-22 21:25               ` Stefan Wahren
2014-09-22 22:18               ` Fabio Estevam
2014-09-22 22:18                 ` Fabio Estevam
2014-09-24 20:46                 ` Stefan Wahren
2014-09-24 20:46                   ` Stefan Wahren
2014-09-24 21:47                   ` Fabio Estevam
2014-09-24 21:47                     ` Fabio Estevam
2014-09-25 18:24                     ` Stefan Wahren
2014-09-25 18:24                       ` Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54055116.4030608@lategoodbye.de \
    --to=info@lategoodbye.de \
    --cc=cpufreq@vger.kernel.org \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=otavio@ossystems.com.br \
    --cc=shawn.guo@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.