From: Nick Dyer <nick.dyer@itdev.co.uk>
To: "Javier Martinez Canillas" <javier.martinez@collabora.co.uk>,
"Andreas Färber" <afaerber@suse.de>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olof@lixom.net>,
Yufeng Shen <miletus@chromium.org>,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Tomasz Figa <tomasz.figa@gmail.com>,
Daniel Stone <daniels@collabora.com>
Subject: Re: [PATCH v2 1/3] ARM: dts: Add Peach Pit dts entry for Atmel touchpad
Date: Tue, 02 Sep 2014 14:46:55 +0100 [thread overview]
Message-ID: <5405CA4F.10507@itdev.co.uk> (raw)
In-Reply-To: <53FDE9B2.4040001@collabora.co.uk>
On 27/08/14 15:22, Javier Martinez Canillas wrote:
>>> If there was a BTN_NONE or KEY_UNUSED it would had been better but I think
>>> that making a distinction between these two cases (reserved pin vs GPIO
>>> available but not used) is useful.
>>
>> Maybe Nick can comment here.
Yes, this is probably useful to document. However, I fear that it's not
going to be obvious what the distinction is to someone who doesn't have the
Atmel docs. Perhaps it would be clearer to just do something like:
linux,gpio-keymap = <KEY_RESERVED
KEY_RESERVED
KEY_RESERVED /* GPIO0 */
KEY_RESERVED /* GPIO1 */
KEY_RESERVED /* GPIO2 */
BTN_LEFT>; /* GPIO3 */
If you omit any trailing KEY_RESERVED values it doesn't affect anything.
I was also going to suggest that you put something like "/* Atmel mXT224SL
*/" in your .dts file so it's clear what version of the maXTouch device you
are configuring.
WARNING: multiple messages have this Message-ID (diff)
From: nick.dyer@itdev.co.uk (Nick Dyer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] ARM: dts: Add Peach Pit dts entry for Atmel touchpad
Date: Tue, 02 Sep 2014 14:46:55 +0100 [thread overview]
Message-ID: <5405CA4F.10507@itdev.co.uk> (raw)
In-Reply-To: <53FDE9B2.4040001@collabora.co.uk>
On 27/08/14 15:22, Javier Martinez Canillas wrote:
>>> If there was a BTN_NONE or KEY_UNUSED it would had been better but I think
>>> that making a distinction between these two cases (reserved pin vs GPIO
>>> available but not used) is useful.
>>
>> Maybe Nick can comment here.
Yes, this is probably useful to document. However, I fear that it's not
going to be obvious what the distinction is to someone who doesn't have the
Atmel docs. Perhaps it would be clearer to just do something like:
linux,gpio-keymap = <KEY_RESERVED
KEY_RESERVED
KEY_RESERVED /* GPIO0 */
KEY_RESERVED /* GPIO1 */
KEY_RESERVED /* GPIO2 */
BTN_LEFT>; /* GPIO3 */
If you omit any trailing KEY_RESERVED values it doesn't affect anything.
I was also going to suggest that you put something like "/* Atmel mXT224SL
*/" in your .dts file so it's clear what version of the maXTouch device you
are configuring.
next prev parent reply other threads:[~2014-09-02 13:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 15:28 [PATCH v2 0/3] Add Atmel maXTouch support for Peach Pit Javier Martinez Canillas
2014-08-26 15:28 ` Javier Martinez Canillas
2014-08-26 15:28 ` [PATCH v2 1/3] ARM: dts: Add Peach Pit dts entry for Atmel touchpad Javier Martinez Canillas
2014-08-26 15:28 ` Javier Martinez Canillas
2014-08-26 22:53 ` Andreas Färber
2014-08-26 22:53 ` Andreas Färber
2014-08-27 7:13 ` Javier Martinez Canillas
2014-08-27 7:13 ` Javier Martinez Canillas
2014-08-27 13:11 ` Andreas Färber
2014-08-27 13:11 ` Andreas Färber
2014-08-27 14:22 ` Javier Martinez Canillas
2014-08-27 14:22 ` Javier Martinez Canillas
2014-09-02 13:46 ` Nick Dyer [this message]
2014-09-02 13:46 ` Nick Dyer
2014-09-08 7:26 ` Javier Martinez Canillas
2014-09-08 7:26 ` Javier Martinez Canillas
2014-08-26 15:28 ` [PATCH v2 2/3] ARM: exynos_defconfig: Enable Atmel maXTouch support Javier Martinez Canillas
2014-08-26 15:28 ` Javier Martinez Canillas
2014-08-26 15:28 ` [PATCH v2 3/3] ARM: multi_v7_defconfig: " Javier Martinez Canillas
2014-08-26 15:28 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5405CA4F.10507@itdev.co.uk \
--to=nick.dyer@itdev.co.uk \
--cc=afaerber@suse.de \
--cc=daniels@collabora.com \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=miletus@chromium.org \
--cc=olof@lixom.net \
--cc=sjoerd.simons@collabora.co.uk \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.