From: Max Reitz <mreitz@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
jenelson@redhat.com, Fam Zheng <famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/2] qemu-img: clarify src_cache option documentation
Date: Tue, 02 Sep 2014 21:10:14 +0200 [thread overview]
Message-ID: <54061616.3070401@redhat.com> (raw)
In-Reply-To: <1409652063-32336-2-git-send-email-stefanha@redhat.com>
On 02.09.2014 12:01, Stefan Hajnoczi wrote:
> The source cache option takes the same values as the cache option. The
> documentation reads a little strange because it starts with "In contrast
> the src_cache option ...". The fact that this is comparing with the
> previous documented option (the 'cache' option) is implicit. Readers
> may be confused, especially if they jump to src_cache without reading
> cache documentation first.
>
> Suggested-by: Jeff Nelson <jenelson@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> qemu-img.c | 3 ++-
> qemu-img.texi | 5 +++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
next prev parent reply other threads:[~2014-09-02 19:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 10:01 [Qemu-devel] [PATCH v2 0/2] qemu-img: src_mode option documentation improvements Stefan Hajnoczi
2014-09-02 10:01 ` [Qemu-devel] [PATCH v2 1/2] qemu-img: clarify src_cache option documentation Stefan Hajnoczi
2014-09-02 19:10 ` Max Reitz [this message]
2014-09-02 10:01 ` [Qemu-devel] [PATCH v2 2/2] qemu-img: fix rebase " Stefan Hajnoczi
2014-09-02 19:10 ` Max Reitz
2014-09-03 10:36 ` [Qemu-devel] [PATCH v2 0/2] qemu-img: src_mode option documentation improvements Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54061616.3070401@redhat.com \
--to=mreitz@redhat.com \
--cc=famz@redhat.com \
--cc=jenelson@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.