Re: [Qemu-devel] [PATCH v2 2/2] qemu-img: fix rebase src_cache option documentation

[Max Reitz <mreitz@redhat.com>]

On 02.09.2014 12:01, Stefan Hajnoczi wrote:
> The src_cache option (-T) specifies the cache mode for backing files.
> It applies both the image's old backing file as well as the new backing
> file:
>
>    ret = bdrv_open(&bs_old_backing, backing_name, NULL, NULL, src_flags,
>                    old_backing_drv, &local_err);
>    if (ret) {
>        ...
>    }
>    if (out_baseimg[0]) {
>        bs_new_backing = bdrv_new("new_backing", &error_abort);
>        ret = bdrv_open(&bs_new_backing, out_baseimg, NULL, NULL, src_flags,
>                        new_backing_drv, &local_err);
>        if (ret) {
>            ...
>        }
>    }
>
> The documentation only mentions the new backing file but it really
> applies to both.
>
> Suggested-by: Jeff Nelson <jenelson@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>   qemu-img.texi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>