Re: [PATCH RFC V11 2/5] xen: Optimize introspection access to guest state

[Razvan Cojocaru <rcojocaru@bitdefender.com>]

On 09/03/2014 04:06 PM, Ian Campbell wrote:
> On Tue, 2014-09-02 at 18:37 +0300, Razvan Cojocaru wrote:
>>  
>>  void *xc_mem_access_enable(xc_interface *xch, domid_t domain_id, uint32_t *port)
>>  {
>> -    return xc_mem_event_enable(xch, domain_id, HVM_PARAM_ACCESS_RING_PFN, port);
>> +    return xc_mem_event_enable(xch, domain_id, HVM_PARAM_ACCESS_RING_PFN,
>> +                               port, 0);
>> +}
>> +
>> +void *xc_mem_access_enable_introspection(xc_interface *xch, domid_t domain_id,
>> +                                         uint32_t *port)
> 
> I'm not really sure the _introspection suffix is the best description of
> what is actually going on here. It looks more like an "extended context
> in event" type thing or something AFAICT.
> 
> But none the less the code seems correct even if the naming isn't ideal,
> so for the toolstack side:
> 
> Acked-by: Ian Campbell <ian.campbell@citrix.com>

Thanks! I'll make sure to add the Acked-by tag to the next iteration of
the series (in the meantime it's become [PATCH V2]).


Thanks,
Razvan Cojocaru