Re: [REGRESSION] "efi: efistub: Convert into static library" and preparation patches

[Maarten Lankhorst <maarten.lankhorst@canonical.com>]

Hey,

Op 03-09-14 om 14:18 schreef Ard Biesheuvel:
> Could you please try adding the visibility attribute lik this instead?
>
> diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h
> index 044a2fd3c5fe..8725d85f1903 100644
> --- a/arch/x86/include/asm/efi.h
> +++ b/arch/x86/include/asm/efi.h
> @@ -178,7 +178,7 @@ struct efi_config {
>         bool is64;
>  } __packed;
>
> -extern struct efi_config *efi_early;
> +extern __attribute__((visibility("hidden"))) struct efi_config *efi_early;
>
>  #define efi_call_early(f, ...)                                         \
>         efi_early->call(efi_early->f, __VA_ARGS__);
>
> Before this change, I get 18 R_X86_64_GOTPCREL relocations pointing to
> efi_early, both in efi-stub-helper.c and eboot.c.
> After the change, I get 0, using 'readelf -a
> drivers/firmware/efi/libstub/efi-stub-helper.o
> arch/x86/boot/compressed/eboot.o|grep GOTPCREL|wc -l'
>
Yeah that fixes things!

Feel free to slap on a reported-reviewed-and-tested-by on your patch. :-)

~Maarten