All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
To: Ulf Winkelvos <ulf-rS3t9PEbhQ0OIzVOb1FTxg@public.gmane.org>,
	Matt Fleming
	<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Seth Forshee
	<seth.forshee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
Subject: [REGRESSION] "efi: efistub: Convert into static library" and preparation patches
Date: Tue, 02 Sep 2014 17:25:58 +0200	[thread overview]
Message-ID: <5405E186.2080406@canonical.com> (raw)

Hey,

My macbook pro 8.2 fails to do a efi stub boot with these patches.

Commit f23cf8bd5c1f49 "efi/x86: efistub: Move shared dependencies to <asm/efi.h>"
causes the first break, but this can be averted by changing

struct efi_config *efi_early;

to

struct efi_config *efi_early __attribute__((visibility("hidden")));

I also need to revert commit f4f75ad5741fe "efi: efistub: Convert into static library"
to get boot working.

I'm not an early boot expert, so I have no idea what's going on here.
Only console output I see when the boot fails is "setup_efi_pci() failed!" after
the commit that adds this message.

~Maarten

WARNING: multiple messages have this Message-ID (diff)
From: Maarten Lankhorst <maarten.lankhorst@canonical.com>
To: Ulf Winkelvos <ulf@winkelvos.de>, Matt Fleming <matt.fleming@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	linux-efi@vger.kernel.org,
	Seth Forshee <seth.forshee@canonical.com>
Subject: [REGRESSION] "efi: efistub: Convert into static library" and preparation patches
Date: Tue, 02 Sep 2014 17:25:58 +0200	[thread overview]
Message-ID: <5405E186.2080406@canonical.com> (raw)

Hey,

My macbook pro 8.2 fails to do a efi stub boot with these patches.

Commit f23cf8bd5c1f49 "efi/x86: efistub: Move shared dependencies to <asm/efi.h>"
causes the first break, but this can be averted by changing

struct efi_config *efi_early;

to

struct efi_config *efi_early __attribute__((visibility("hidden")));

I also need to revert commit f4f75ad5741fe "efi: efistub: Convert into static library"
to get boot working.

I'm not an early boot expert, so I have no idea what's going on here.
Only console output I see when the boot fails is "setup_efi_pci() failed!" after
the commit that adds this message.

~Maarten


             reply	other threads:[~2014-09-02 15:25 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02 15:25 Maarten Lankhorst [this message]
2014-09-02 15:25 ` [REGRESSION] "efi: efistub: Convert into static library" and preparation patches Maarten Lankhorst
2014-09-02 19:29 ` Matt Fleming
2014-09-03  6:06   ` Ard Biesheuvel
     [not found]     ` <CAKv+Gu_eSe+FeNkGm+w3sSsRn2_hr70xLVBieZgyhawAv6PQvw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-03  8:27       ` Maarten Lankhorst
2014-09-03  8:27         ` Maarten Lankhorst
     [not found]         ` <5406D0DB.90401-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2014-09-03 12:18           ` Ard Biesheuvel
2014-09-03 12:18             ` Ard Biesheuvel
2014-09-03 15:30             ` Maarten Lankhorst
     [not found]               ` <54073409.6030004-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2014-09-03 15:37                 ` Ard Biesheuvel
2014-09-03 15:37                   ` Ard Biesheuvel
     [not found]                   ` <CAKv+Gu9q1qTh6DZXsCG2tGVBn-uwuQKQa_6FEMmchDVFi5vJtw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-03 17:59                     ` Matt Fleming
2014-09-03 17:59                       ` Matt Fleming
     [not found]                       ` <20140903175948.GH3001-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-03 19:57                         ` Ard Biesheuvel
2014-09-03 19:57                           ` Ard Biesheuvel
     [not found]                           ` <CAKv+Gu9tejixb3Kb3YM_7sLcpKNuRHN+Dn+twFyCAXx99wYRCw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-03 21:28                             ` H. Peter Anvin
2014-09-03 21:28                               ` H. Peter Anvin
2014-09-04 10:48                             ` Maarten Lankhorst
2014-09-04 10:48                               ` Maarten Lankhorst
     [not found]                               ` <54084376.8090002-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org>
2014-09-04 11:19                                 ` Ard Biesheuvel
2014-09-04 11:19                                   ` Ard Biesheuvel
     [not found]                                   ` <BA3DE6F4-93D9-4CDE-90D7-280360929ABD-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-09-04 11:24                                     ` Maarten Lankhorst
2014-09-04 11:24                                       ` Maarten Lankhorst
2014-09-04 12:54                                 ` Michael Brown
2014-09-04 12:54                                   ` Michael Brown
     [not found]                                   ` <540860F1.6060801-OViyBiuKJBuK421+ScFKDQ@public.gmane.org>
2014-09-04 19:12                                     ` Ard Biesheuvel
2014-09-04 19:12                                       ` Ard Biesheuvel
2014-09-04 21:25                                       ` Ard Biesheuvel
     [not found]                                         ` <CAKv+Gu_sLmkBHF-9GyPUgfAbLYirQTD4vk63o6HzdZhm6s_e0g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-04 21:37                                           ` Matt Fleming
2014-09-04 21:37                                             ` Matt Fleming
     [not found]                                             ` <20140904213753.GM3001-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-05 20:27                                               ` Matt Fleming
2014-09-05 20:27                                                 ` Matt Fleming
     [not found]                                                 ` <20140905202744.GO3001-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2014-09-08 12:55                                                   ` Ard Biesheuvel
2014-09-08 12:55                                                     ` Ard Biesheuvel
     [not found]                                                     ` <CAKv+Gu8GOHMa=zVWBG7OdSG2i2Ag_XyEBE5NzU6ffLNP8zA3Ug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-08 13:01                                                       ` Maarten Lankhorst
2014-09-08 13:01                                                         ` Maarten Lankhorst
2014-09-08 13:16                                                         ` Matt Fleming
2014-09-22 18:44                                                 ` Josh Boyer
2014-09-22 21:07                                                   ` Matt Fleming
2014-09-22 21:24                                                     ` Josh Boyer
2014-09-03 21:47                         ` H. Peter Anvin
2014-09-03 21:47                           ` H. Peter Anvin
     [not found]                           ` <54078C74.2060804-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2014-09-04  6:47                             ` Ard Biesheuvel
2014-09-04  6:47                               ` Ard Biesheuvel
2014-09-04  7:40                               ` Matt Fleming
2014-09-04  7:50                                 ` Maarten Lankhorst
2014-09-04  7:29                           ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5405E186.2080406@canonical.com \
    --to=maarten.lankhorst-z7wlfzj8ewms+fvcfc7uqw@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=seth.forshee-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org \
    --cc=ulf-rS3t9PEbhQ0OIzVOb1FTxg@public.gmane.org \
    --cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.