All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH Resend] memfd_test: Add missing argument to printf()
@ 2014-09-04 15:58 ` Pranith Kumar
  0 siblings, 0 replies; 4+ messages in thread
From: Pranith Kumar @ 2014-09-04 15:58 UTC (permalink / raw)
  To: Shuah Khan, Andrew Morton, Hugh Dickins, David Herrmann,
	open list:KERNEL SELFTEST F..., open list

Add a missing path argument buf to printf() 

Signed-off-by: Pranith Kumar <bobby.prani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Reviewed-by: David Herrmann <dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 tools/testing/selftests/memfd/memfd_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
index 3634c90..c343df8 100644
--- a/tools/testing/selftests/memfd/memfd_test.c
+++ b/tools/testing/selftests/memfd/memfd_test.c
@@ -205,7 +205,7 @@ static void mfd_fail_open(int fd, int flags, mode_t mode)
 	sprintf(buf, "/proc/self/fd/%d", fd);
 	r = open(buf, flags, mode);
 	if (r >= 0) {
-		printf("open(%s) didn't fail as expected\n");
+		printf("open(%s) didn't fail as expected\n", buf);
 		abort();
 	}
 }
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH Resend] memfd_test: Add missing argument to printf()
@ 2014-09-04 15:58 ` Pranith Kumar
  0 siblings, 0 replies; 4+ messages in thread
From: Pranith Kumar @ 2014-09-04 15:58 UTC (permalink / raw)
  To: Shuah Khan, Andrew Morton, Hugh Dickins, David Herrmann,
	open list:KERNEL SELFTEST F..., open list

Add a missing path argument buf to printf() 

Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
---
 tools/testing/selftests/memfd/memfd_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
index 3634c90..c343df8 100644
--- a/tools/testing/selftests/memfd/memfd_test.c
+++ b/tools/testing/selftests/memfd/memfd_test.c
@@ -205,7 +205,7 @@ static void mfd_fail_open(int fd, int flags, mode_t mode)
 	sprintf(buf, "/proc/self/fd/%d", fd);
 	r = open(buf, flags, mode);
 	if (r >= 0) {
-		printf("open(%s) didn't fail as expected\n");
+		printf("open(%s) didn't fail as expected\n", buf);
 		abort();
 	}
 }
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH Resend] memfd_test: Add missing argument to printf()
  2014-09-04 15:58 ` Pranith Kumar
@ 2014-09-04 18:31     ` Shuah Khan
  -1 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2014-09-04 18:31 UTC (permalink / raw)
  To: Pranith Kumar, Andrew Morton, Hugh Dickins, David Herrmann,
	open list:KERNEL SELFTEST F..., open list, Shuah Khan

On 09/04/2014 09:58 AM, Pranith Kumar wrote:
> Add a missing path argument buf to printf() 
> 
> Signed-off-by: Pranith Kumar <bobby.prani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Reviewed-by: David Herrmann <dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  tools/testing/selftests/memfd/memfd_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
> index 3634c90..c343df8 100644
> --- a/tools/testing/selftests/memfd/memfd_test.c
> +++ b/tools/testing/selftests/memfd/memfd_test.c
> @@ -205,7 +205,7 @@ static void mfd_fail_open(int fd, int flags, mode_t mode)
>  	sprintf(buf, "/proc/self/fd/%d", fd);
>  	r = open(buf, flags, mode);
>  	if (r >= 0) {
> -		printf("open(%s) didn't fail as expected\n");
> +		printf("open(%s) didn't fail as expected\n", buf);
>  		abort();
>  	}
>  }
> 

Thanks. I queued it for 3.17 fixes.

-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH Resend] memfd_test: Add missing argument to printf()
@ 2014-09-04 18:31     ` Shuah Khan
  0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2014-09-04 18:31 UTC (permalink / raw)
  To: Pranith Kumar, Andrew Morton, Hugh Dickins, David Herrmann,
	open list:KERNEL SELFTEST F..., open list, Shuah Khan

On 09/04/2014 09:58 AM, Pranith Kumar wrote:
> Add a missing path argument buf to printf() 
> 
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
> Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
> ---
>  tools/testing/selftests/memfd/memfd_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c
> index 3634c90..c343df8 100644
> --- a/tools/testing/selftests/memfd/memfd_test.c
> +++ b/tools/testing/selftests/memfd/memfd_test.c
> @@ -205,7 +205,7 @@ static void mfd_fail_open(int fd, int flags, mode_t mode)
>  	sprintf(buf, "/proc/self/fd/%d", fd);
>  	r = open(buf, flags, mode);
>  	if (r >= 0) {
> -		printf("open(%s) didn't fail as expected\n");
> +		printf("open(%s) didn't fail as expected\n", buf);
>  		abort();
>  	}
>  }
> 

Thanks. I queued it for 3.17 fixes.

-- Shuah

-- 
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-04 18:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-04 15:58 [PATCH Resend] memfd_test: Add missing argument to printf() Pranith Kumar
2014-09-04 15:58 ` Pranith Kumar
     [not found] ` <1409846302-3513-1-git-send-email-bobby.prani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-09-04 18:31   ` Shuah Khan
2014-09-04 18:31     ` Shuah Khan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.