From: Sasha Levin <sasha.levin@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: oleg@redhat.com, riel@redhat.com,
kirill.shutemov@linux.intel.com, luto@amacapital.net,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: mmap: use pr_emerg when printing BUG related information
Date: Thu, 04 Sep 2014 16:50:46 -0400 [thread overview]
Message-ID: <5408D0A6.9040505@oracle.com> (raw)
In-Reply-To: <20140904133058.37ca7aa2e46a607eed94df3b@linux-foundation.org>
On 09/04/2014 04:30 PM, Andrew Morton wrote:
> On Thu, 4 Sep 2014 14:36:22 -0400 Sasha Levin <sasha.levin@oracle.com> wrote:
>
>> Make sure we actually see the output of validate_mm() and browse_rb()
>> before triggering a BUG(). pr_info isn't shown by default so the reason
>> for the BUG() isn't obvious.
>>
>
> yup, I'll scoot that into 3.17.
>
>
> That code's actually pretty cruddy. How does this look?
The patch looks good.
I've got sidetracked and started working on dump_mm()...
Thanks,
Sasha
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sasha Levin <sasha.levin@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: oleg@redhat.com, riel@redhat.com,
kirill.shutemov@linux.intel.com, luto@amacapital.net,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: mmap: use pr_emerg when printing BUG related information
Date: Thu, 04 Sep 2014 16:50:46 -0400 [thread overview]
Message-ID: <5408D0A6.9040505@oracle.com> (raw)
In-Reply-To: <20140904133058.37ca7aa2e46a607eed94df3b@linux-foundation.org>
On 09/04/2014 04:30 PM, Andrew Morton wrote:
> On Thu, 4 Sep 2014 14:36:22 -0400 Sasha Levin <sasha.levin@oracle.com> wrote:
>
>> Make sure we actually see the output of validate_mm() and browse_rb()
>> before triggering a BUG(). pr_info isn't shown by default so the reason
>> for the BUG() isn't obvious.
>>
>
> yup, I'll scoot that into 3.17.
>
>
> That code's actually pretty cruddy. How does this look?
The patch looks good.
I've got sidetracked and started working on dump_mm()...
Thanks,
Sasha
next prev parent reply other threads:[~2014-09-04 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 18:36 [PATCH] mm: mmap: use pr_emerg when printing BUG related information Sasha Levin
2014-09-04 18:36 ` Sasha Levin
2014-09-04 20:30 ` Andrew Morton
2014-09-04 20:30 ` Andrew Morton
2014-09-04 20:50 ` Sasha Levin [this message]
2014-09-04 20:50 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5408D0A6.9040505@oracle.com \
--to=sasha.levin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@amacapital.net \
--cc=oleg@redhat.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.