From: Randy MacLeod <randy.macleod@windriver.com>
To: <openembedded-devel@lists.openembedded.org>,
Robert Yang <liezhi.yang@windriver.com>
Subject: Re: [PATCH 11/13] sdparm: add bash to RDEPENDS_sdparm
Date: Thu, 4 Sep 2014 17:10:37 -0400 [thread overview]
Message-ID: <5408D54D.8090007@windriver.com> (raw)
In-Reply-To: <76dbc052fe60d5e4e5ba929e8e274cdf5c7572e2.1409584344.git.liezhi.yang@windriver.com>
On 14-09-01 11:18 AM, Robert Yang wrote:
> Bash scripts:
> packages-split/sdparm/usr/bin/sas_disk_blink:#!/bin/bash
> packages-split/sdparm/usr/bin/scsi_ch_swp:#!/bin/bash
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
> meta-oe/recipes-support/sdparm/sdparm_1.08.bb | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/meta-oe/recipes-support/sdparm/sdparm_1.08.bb b/meta-oe/recipes-support/sdparm/sdparm_1.08.bb
> index 713e451..be46b96 100644
> --- a/meta-oe/recipes-support/sdparm/sdparm_1.08.bb
> +++ b/meta-oe/recipes-support/sdparm/sdparm_1.08.bb
> @@ -15,3 +15,5 @@ SRC_URI[md5sum] = "be5786f37499018ef44f409597c92d42"
> SRC_URI[sha256sum] = "376b78a414b1a9c47f3f13dbeb963e7a3ec7be126f83927d6856b5f7ac425e57"
>
> inherit autotools
> +
> +RDEPENDS_${PN} += "bash"
>
We should move these scripts to a sdparm-scripts sub-pkg.
sdparm is a ~150K executable so making it pull in bash
at >1000K isn't good for embedded systems.
Neither script appears to be essential:
sas_disk_blink - blink the LED on a SAS disk
scsi_ch_swp:
"Usage: scsi_ch_swp [-h] [-s 0|1] [-v] [-w] <blk_device>"
...
"Access the Software Write Protect (SWP) bit in the SCSI control"
"mode page and if changed adjust the Linux block device (e.g."
"/dev/sdc) settings accordingly. If supported, when the SWP bit"
"is set (1) the device is read-only; when clear (0) the device"
"is read-write (i.e. its contents can be read and changed)."
"When no options given it reads SWP and gets blockdev's RO flag."
Comments or concerns?
--
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350
next prev parent reply other threads:[~2014-09-04 21:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-01 15:18 [PATCH 00/13] fix RDEPENDS issues Robert Yang
2014-09-01 15:18 ` [PATCH 01/13] aoetools: no bashism in aoe-stat Robert Yang
2014-09-01 15:18 ` [PATCH 02/13] autofs: add bash to RDEPENDS_autofs Robert Yang
2014-09-01 15:18 ` [PATCH 03/13] arptables: add bash to RDEPENDS_arptables Robert Yang
2014-09-18 7:42 ` Khem Raj
2014-09-19 3:03 ` Robert Yang
2014-09-01 15:18 ` [PATCH 04/13] ndisc6: add perl to RDEPENDS_ndisc6-misc Robert Yang
2014-09-01 15:18 ` [PATCH 05/13] stunnel: add perl to RDEPENDS_stunnel Robert Yang
2014-09-01 15:18 ` [PATCH 06/13] proftpd: add perl to RDEPENDS_proftpd Robert Yang
2014-09-01 15:18 ` [PATCH 07/13] memcached: add bash to RDEPENDS_memcached Robert Yang
2014-09-01 15:18 ` [PATCH 08/13] phpmyadmin: add bash to RDEPENDS_phpmyadmin Robert Yang
2014-09-01 15:18 ` [PATCH 09/13] apache2: add perl to RDEPENDS_apache2 Robert Yang
2014-09-02 8:31 ` Olof Johansson
2014-09-02 8:45 ` Robert Yang
2014-09-02 8:52 ` Olof Johansson
2014-09-02 12:54 ` [PATCH 09/13] apache2: split apache2-scripts subpkg Robert Yang
2014-09-01 15:18 ` [PATCH 10/13] sg3-utils: add bash to RDEPENDS_sg3-utils Robert Yang
2014-09-01 15:18 ` [PATCH 11/13] sdparm: add bash to RDEPENDS_sdparm Robert Yang
2014-09-04 21:10 ` Randy MacLeod [this message]
2014-09-05 1:58 ` Robert Yang
2014-09-01 15:18 ` [PATCH 12/13] bonnie: add perl to RDEPENDS_bonnie-scripts Robert Yang
2014-09-01 15:18 ` [PATCH 13/13] rrdtool: use rrdtool rather than PN Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5408D54D.8090007@windriver.com \
--to=randy.macleod@windriver.com \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.