All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Niklas Hambüchen" <mail@nh2.me>
To: git@vger.kernel.org
Cc: petr.mvd@gmail.com
Subject: git format-patch --in-reply-to allows header injection. Intended?
Date: Thu, 04 Sep 2014 23:21:49 +0200	[thread overview]
Message-ID: <5408D7ED.9010203@nh2.me> (raw)

Hi,

I just wanted to ask if the --in-reply-to flag of git format-patch is
supposed to write the given string unmodified into the email or whether
it ought to perform some check against header injection.

For example, if you pass "--in-reply-to=<msgid>\nTo: <other@example.com"
(notice lack of trailing `>`), then the generated email will actually
contain a
  To: <other@example.com>
header.

(Depending on your shell you might also use "--in-reply-to=`cat`" to get
the above working more easily.)

Is this known and working as intended, or undesired?

Thanks!
Niklas

             reply	other threads:[~2014-09-04 21:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04 21:21 Niklas Hambüchen [this message]
2014-09-04 21:36 ` git format-patch --in-reply-to allows header injection. Intended? Junio C Hamano
2014-09-04 21:42   ` Niklas Hambüchen
2014-09-04 23:59     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5408D7ED.9010203@nh2.me \
    --to=mail@nh2.me \
    --cc=git@vger.kernel.org \
    --cc=petr.mvd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.