All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Niklas Hambüchen" <mail@nh2.me>
Cc: git@vger.kernel.org, petr.mvd@gmail.com
Subject: Re: git format-patch --in-reply-to allows header injection. Intended?
Date: Thu, 04 Sep 2014 14:36:09 -0700	[thread overview]
Message-ID: <xmqqppfbqd9x.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <5408D7ED.9010203@nh2.me> ("Niklas Hambüchen"'s message of "Thu, 04 Sep 2014 23:21:49 +0200")

Niklas Hambüchen <mail@nh2.me> writes:

> For example, if you pass "--in-reply-to=<msgid>\nTo: <other@example.com"
> (notice lack of trailing `>`), then the generated email will actually
> contain a
>   To: <other@example.com>
> header.

While I do not think of a reason to specify such a string to the
in-reply-to option (I'd rather edit the output in the editor if I
wanted to do anything fancy [*1*]), I do not think there is a reason
why you want to add a code to forbid such use, either.


[Footnote]

*1* For that matter, --in-reply-to option itself is superfluous.

  reply	other threads:[~2014-09-04 21:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-04 21:21 git format-patch --in-reply-to allows header injection. Intended? Niklas Hambüchen
2014-09-04 21:36 ` Junio C Hamano [this message]
2014-09-04 21:42   ` Niklas Hambüchen
2014-09-04 23:59     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqppfbqd9x.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mail@nh2.me \
    --cc=petr.mvd@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.