From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mike Turquette <mturquette@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Pavel Kiryukhin <vksavl@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] clk-rcar-gen2: RCAN clock support
Date: Fri, 05 Sep 2014 15:47:49 +0000 [thread overview]
Message-ID: <5409DB25.3070204@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdUoZ3AX-y51BaBuodu1Lmw1SvzvGUNNEtfPvfYdsWJOCw@mail.gmail.com>
On 09/05/2014 01:17 PM, Geert Uytterhoeven wrote:
>>>> Add RCAN clock support to the R-Car generation 2 CPG driver. This clock
>>>> gets
>>>> derived from the USB_EXTAL clock by dividing it by 6. The layout of
>>>> RCANCKCR
>>>> register is close to those of the clocks supported by the 'clk-div6'
>>>> driver
>>>> but has no divider field, and so can't be supported by that driver...
>> I'm not a clock expert (pulling in Laurent), but it looks fine to me.
> While you did add the rcan clock to the dtsi in "[PATCH v3 1/3] ARM:
> shmobile: r8a7791: add CAN clocks", I couldn't find a patch to update
> the renesas,rcar-gen2-cpg-clocks binding doc?
Thanks, I didn't know I need to update the bindings as well...
> Gr{oetje,eeting}s,
> Geert
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mike Turquette <mturquette@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Pavel Kiryukhin <vksavl@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] clk-rcar-gen2: RCAN clock support
Date: Fri, 05 Sep 2014 19:47:49 +0400 [thread overview]
Message-ID: <5409DB25.3070204@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdUoZ3AX-y51BaBuodu1Lmw1SvzvGUNNEtfPvfYdsWJOCw@mail.gmail.com>
On 09/05/2014 01:17 PM, Geert Uytterhoeven wrote:
>>>> Add RCAN clock support to the R-Car generation 2 CPG driver. This clock
>>>> gets
>>>> derived from the USB_EXTAL clock by dividing it by 6. The layout of
>>>> RCANCKCR
>>>> register is close to those of the clocks supported by the 'clk-div6'
>>>> driver
>>>> but has no divider field, and so can't be supported by that driver...
>> I'm not a clock expert (pulling in Laurent), but it looks fine to me.
> While you did add the rcan clock to the dtsi in "[PATCH v3 1/3] ARM:
> shmobile: r8a7791: add CAN clocks", I couldn't find a patch to update
> the renesas,rcar-gen2-cpg-clocks binding doc?
Thanks, I didn't know I need to update the bindings as well...
> Gr{oetje,eeting}s,
> Geert
WBR, Sergei
next prev parent reply other threads:[~2014-09-05 15:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-30 20:23 [PATCH] clk-rcar-gen2: RCAN clock support Sergei Shtylyov
2014-07-30 20:23 ` Sergei Shtylyov
2014-09-03 19:57 ` Sergei Shtylyov
2014-09-03 19:57 ` Sergei Shtylyov
2014-09-05 9:03 ` Geert Uytterhoeven
2014-09-05 9:03 ` Geert Uytterhoeven
2014-09-05 9:17 ` Geert Uytterhoeven
2014-09-05 9:17 ` Geert Uytterhoeven
2014-09-05 15:47 ` Sergei Shtylyov [this message]
2014-09-05 15:47 ` Sergei Shtylyov
2014-09-05 13:33 ` Sergei Shtylyov
2014-09-05 13:33 ` Sergei Shtylyov
2014-09-10 10:36 ` Laurent Pinchart
2014-09-10 10:36 ` Laurent Pinchart
2014-12-23 22:59 ` Sergei Shtylyov
2014-12-23 22:59 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5409DB25.3070204@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=vksavl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.