From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org, chris.j.arges@canonical.com,
kvm@vger.kernel.org, John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH] KVM: x86: fix kvmclock breakage from timers branch merge
Date: Fri, 05 Sep 2014 22:37:54 +0200 [thread overview]
Message-ID: <540A1F22.7020107@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1409052031140.5472@nanos>
Il 05/09/2014 20:33, Thomas Gleixner ha scritto:
>> > update_vsyscall(tk);
>> > - update_pvclock_gtod(tk, action & TK_CLOCK_WAS_SET);
>> >
>> > tk_update_ktime_data(tk);
>> > + update_pvclock_gtod(tk, action & TK_CLOCK_WAS_SET);
> Why are you moving the update between vsycall and pvclock update as I
> did in my patch? We really need to update everything before calling
> somewhere.
Do you mean the call should be moved not just after tk_update_ktime_data
(which sets base_mono), but further down after
update_fast_timekeeper(tk);
?
Paolo
next prev parent reply other threads:[~2014-09-05 20:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 12:58 [PATCH] KVM: x86: fix kvmclock breakage from timers branch merge Paolo Bonzini
2014-09-04 16:00 ` Chris J Arges
2014-09-04 17:14 ` Paolo Bonzini
2014-09-04 18:16 ` Chris J Arges
2014-09-04 19:15 ` Paolo Bonzini
2014-09-04 19:42 ` Paolo Bonzini
2014-09-04 20:37 ` Chris J Arges
2014-09-04 20:40 ` Paolo Bonzini
2014-09-04 20:43 ` Chris J Arges
2014-09-04 19:00 ` John Stultz
2014-09-04 19:14 ` Paolo Bonzini
2014-09-04 17:56 ` Paolo Bonzini
2014-09-04 20:58 ` Thomas Gleixner
2014-09-04 21:22 ` Paolo Bonzini
2014-09-04 22:24 ` Thomas Gleixner
2014-09-05 15:14 ` Thomas Gleixner
2014-09-05 16:39 ` Paolo Bonzini
2014-09-05 18:33 ` Thomas Gleixner
2014-09-05 20:37 ` Paolo Bonzini [this message]
2014-09-05 20:41 ` Thomas Gleixner
2014-09-05 21:00 ` Paolo Bonzini
2014-09-08 15:28 ` Chris J Arges
2014-09-06 11:01 ` [tip:timers/urgent] timekeeping: Update timekeeper before updating vsyscall and pvclock tip-bot for Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2014-09-04 21:05 [PATCH] KVM: x86: fix kvmclock breakage from timers branch merge Paolo Bonzini
2014-09-04 21:27 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540A1F22.7020107@redhat.com \
--to=pbonzini@redhat.com \
--cc=chris.j.arges@canonical.com \
--cc=john.stultz@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.