From: "Peter A. Bigot" <pab@pabigot.com>
To: "meta-ti@yoctoproject.org" <meta-ti@yoctoproject.org>
Subject: mis-definition of SLEWCTRL_FAST in dt-bindings amxxxx header
Date: Sat, 06 Sep 2014 18:17:31 -0500 [thread overview]
Message-ID: <540B960B.6080907@pabigot.com> (raw)
While converting some old DTS bindings, I noticed that the Linux
include/dt-bindings/pinctrl/am33xx.h and am43xx.h headers both define
SLEWCTRL_FAST constants:
include/dt-bindings/pinctrl/am33xx.h:#define SLEWCTRL_FAST
(1 << 6)
include/dt-bindings/pinctrl/am43xx.h:#define SLEWCTRL_FAST
(1 << 19)
According to the TRM for these processors, the effect of setting that
bit is to select slow slew; fast would be selected by leaving it
cleared. The constants should therefore be named SLEWCTRL_SLOW.
This is consistent with the value for the I2C binding constants I'm
converting:
beagleboard/3.14:arch/arm/boot/dts/am335x-bone-common-pinmux.dtsi: 0x158
0x72 /* spi0_d1.i2c1_sda, SLEWCTRL_SLOW | INPUT_PULLUP | MODE2 */
beagleboard/3.14:arch/arm/boot/dts/am335x-bone-common-pinmux.dtsi: 0x15c
0x72 /* spi0_cs0.i2c1_scl, SLEWCTRL_SLOW | INPUT_PULLUP | MODE2 */
except that in the official files we have something like:
stable/linux-3.14.y:arch/arm/boot/dts/am43x-epos-evm.dts: 0x188
(PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE0) /* i2c0_sda.i2c0_sda */
stable/linux-3.14.y:arch/arm/boot/dts/am43x-epos-evm.dts: 0x18c
(PIN_INPUT_PULLUP | SLEWCTRL_FAST | MUX_MODE0) /* i2c0_scl.i2c0_scl */
which is either wrong or misleading.
Peter
next reply other threads:[~2014-09-06 23:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-06 23:17 Peter A. Bigot [this message]
2014-09-17 12:17 ` mis-definition of SLEWCTRL_FAST in dt-bindings amxxxx header Peter A. Bigot
2014-10-07 20:58 ` Denys Dmytriyenko
2014-10-08 23:53 ` Peter A. Bigot
[not found] <549D8379.2060800@inventec.ch>
2014-12-26 16:29 ` Peter A. Bigot
2015-01-09 21:46 ` Denys Dmytriyenko
2015-01-09 23:02 ` Peter A. Bigot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540B960B.6080907@pabigot.com \
--to=pab@pabigot.com \
--cc=meta-ti@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.