From: "Peter A. Bigot" <pab@pabigot.com>
To: Christian d'Heureuse <chdh@inventec.ch>,
"meta-ti@yoctoproject.org" <meta-ti@yoctoproject.org>
Subject: Re: mis-definition of SLEWCTRL_FAST in dt-bindings amxxxx header
Date: Fri, 26 Dec 2014 10:29:39 -0600 [thread overview]
Message-ID: <549D8CF3.4080006@pabigot.com> (raw)
In-Reply-To: <549D8379.2060800@inventec.ch>
On 12/26/2014 09:49 AM, Christian d'Heureuse wrote:
> Hi Peter
>
> I stumbled on the same error in am33xx.h as you described in September:
> https://lists.yoctoproject.org/pipermail/meta-ti/2014-September/005211.html
>
>
> Did you get any reactions?
Just the follow-up theorizing it'd been fixed upstream. As of today,
it's still wrong in both am33xx.h and am43xx.h when "upstream" means the
torvalds master branch.
I keep hoping a TIer will step up, but if not I suppose somebody else
has to do it.
Maybe E2E will yield results.
http://e2e.ti.com/support/arm/sitara_arm/f/791/p/367445/1382229#1382229
Peter
>
> The error is still in the current Linux source:
>
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/include/dt-bindings/pinctrl/am33xx.h
>
>
> #define SLEWCTRL_FAST (1 << 6)
>
> In the old Rowboat kernel, the definition was correct:
>
> https://gitorious.org/rowboat/kernel/source/03f2a1e9ea7f8b11ff6809f5a75b614011f8adb6:arch/arm/mach-omap2/mux.h
>
>
> #define AM33XX_SLEWCTRL_FAST (0 << 6)
> #define AM33XX_SLEWCTRL_SLOW (1 << 6)
>
> An in the AM335X Technical Reference Manual
> http://www.ti.com/lit/ug/spruh73k/spruh73k.pdf
> "slewctrl" bit:
> "9.2.2 Pad Control Registers"
> "9.3.1.50 conf_<module>_<pin> Register"
>
> According to
> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/log/include/dt-bindings/pinctrl/am33xx.h
> the author is
> Florian Vaussard <florian.vaussard@epfl.ch> and the committer is
> Benoit Cousson <benoit.cousson@linaro.org>. Maybe we could write one
> of them?
>
> Christian
> http://www.source-code.biz http://www.inventec.ch/chdh
next parent reply other threads:[~2014-12-26 16:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <549D8379.2060800@inventec.ch>
2014-12-26 16:29 ` Peter A. Bigot [this message]
2015-01-09 21:46 ` mis-definition of SLEWCTRL_FAST in dt-bindings amxxxx header Denys Dmytriyenko
2015-01-09 23:02 ` Peter A. Bigot
2014-09-06 23:17 Peter A. Bigot
2014-09-17 12:17 ` Peter A. Bigot
2014-10-07 20:58 ` Denys Dmytriyenko
2014-10-08 23:53 ` Peter A. Bigot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=549D8CF3.4080006@pabigot.com \
--to=pab@pabigot.com \
--cc=chdh@inventec.ch \
--cc=meta-ti@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.