All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Thomas Hellstrom <thellstrom@vmware.com>
Cc: dmarlin@redhat.com, Josh Boyer <jwboyer@fedoraproject.org>,
	emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, Brian Paul <brianp@vmware.com>
Subject: Re: [PATCH] drm/vmwgfx: Fix drm.h include
Date: Mon, 08 Sep 2014 13:42:21 +0100	[thread overview]
Message-ID: <540DA42D.3080208@gmail.com> (raw)
In-Reply-To: <540D9DC5.8010101@vmware.com>

On 08/09/14 13:15, Thomas Hellstrom wrote:
> Hi!
> 
> On 09/08/2014 02:01 PM, Emil Velikov wrote:
[snip]
>>
>> To the VMware guys,
>>
>> Any objections if we update the libdrm header and drop the mesa/ddx copies ?
>>
>> Cheers,
>> Emil
> Hi!
> 
> vmwgfx libdrm is pretty obsolete and AFAIK not used by anyone.
> As such, it's unnecessary to release a new version of libdrm each time
> the vmwgfx header is updated, and I'd like to avoid that dependency.
> Better to keep the local copies in the gallium winsys and the DDX. Since
> the ioctl interface is backwards compatible, it doesn't really matter if
> the headers are slightly out of sync.
> 
Afaict libdrm releases are dirt cheap, and should not cause any issues. Yet
it's your code so you'll be the judge of it all.

I'm just a de-duplication fanatic :)

-Emil

WARNING: multiple messages have this Message-ID (diff)
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Thomas Hellstrom <thellstrom@vmware.com>
Cc: emil.l.velikov@gmail.com, dmarlin@redhat.com,
	Josh Boyer <jwboyer@fedoraproject.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Brian Paul <brianp@vmware.com>
Subject: Re: [PATCH] drm/vmwgfx: Fix drm.h include
Date: Mon, 08 Sep 2014 13:42:21 +0100	[thread overview]
Message-ID: <540DA42D.3080208@gmail.com> (raw)
In-Reply-To: <540D9DC5.8010101@vmware.com>

On 08/09/14 13:15, Thomas Hellstrom wrote:
> Hi!
> 
> On 09/08/2014 02:01 PM, Emil Velikov wrote:
[snip]
>>
>> To the VMware guys,
>>
>> Any objections if we update the libdrm header and drop the mesa/ddx copies ?
>>
>> Cheers,
>> Emil
> Hi!
> 
> vmwgfx libdrm is pretty obsolete and AFAIK not used by anyone.
> As such, it's unnecessary to release a new version of libdrm each time
> the vmwgfx header is updated, and I'd like to avoid that dependency.
> Better to keep the local copies in the gallium winsys and the DDX. Since
> the ioctl interface is backwards compatible, it doesn't really matter if
> the headers are slightly out of sync.
> 
Afaict libdrm releases are dirt cheap, and should not cause any issues. Yet
it's your code so you'll be the judge of it all.

I'm just a de-duplication fanatic :)

-Emil


  reply	other threads:[~2014-09-08 12:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05 17:19 [PATCH] drm/vmwgfx: Fix drm.h include Josh Boyer
2014-09-08 12:01 ` Emil Velikov
2014-09-08 12:01   ` Emil Velikov
2014-09-08 12:14   ` Josh Boyer
2014-09-08 12:26     ` Emil Velikov
2014-09-08 12:26       ` Emil Velikov
2014-09-08 12:15   ` Thomas Hellstrom
2014-09-08 12:15     ` Thomas Hellstrom
2014-09-08 12:42     ` Emil Velikov [this message]
2014-09-08 12:42       ` Emil Velikov
2014-09-16 13:43 ` Josh Boyer
2014-09-17  0:03   ` Dave Airlie
2014-09-17  0:03     ` Dave Airlie
2014-09-22 19:58   ` Julien Cristau
2014-09-22 19:58     ` Julien Cristau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540DA42D.3080208@gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=brianp@vmware.com \
    --cc=dmarlin@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jwboyer@fedoraproject.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thellstrom@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.