All of lore.kernel.org
 help / color / mirror / Atom feed
From: behanw@converseincode.com (Behan Webster)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: LLVMLinux: Provide __aeabi_* symbols which are needed for clang
Date: Mon, 08 Sep 2014 16:53:39 -0500	[thread overview]
Message-ID: <540E2563.8020909@converseincode.com> (raw)
In-Reply-To: <CAFzeTN10iz0eMTVqdRhzvqKagyB7srEZN8YAUOJzxzfJihv62Q@mail.gmail.com>

On 09/08/14 16:01, Mark Charlebois wrote:
> On Sun, Sep 7, 2014 at 12:30 AM, Catalin Marinas
> <catalin.marinas@arm.com> wrote:
>> On 7 Sep 2014, at 03:30, Mark Charlebois <charlebm@gmail.com> wrote:
>>> On Sat, Sep 6, 2014 at 7:16 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>>> On Friday 05 September 2014 16:23:14 behanw at converseincode.com wrote:
>>>>> + *  Copyright (C) 2012  Mark Charlebois
>>>>> + */
>>>>> +
>>>>> +/*
>>>>> + * EABI routines
>>>> Does EABI specify these function names? I would think that they are
>>>> just random libgcc (whatever that is called in clang) functions.
>>> http://infocenter.arm.com/help/topic/com.arm.doc.ihi0043d/IHI0043D_rtabi.pdf
>>>
>>> See section 4.3.4 Memory copying, clearing, and setting
>> What does this document have to do with arm64 (AArch64, A64)? We don?t
>> need such symbols on arm64. Also, the arm64 kernel links with libgcc (no
>> immediate need AFAICT but the compiler does not guarantee the intrinsics
>> would always be generated inline).
> [reposting in plain text]
>
> This patch was made early in the arm64 kernel support. I just retested
> and you are correct, it is no longer needed.  My apologies to all.

Whoops. I normally check whether a patch is still needed before posting 
them. I seem to have missed that step this time. My apologies as well.

That all being said, I prefer to see patches no longer required, than 
needing them to be upstreamed, so in that this is a win.

Behan

-- 
Behan Webster
behanw at converseincode.com

WARNING: multiple messages have this Message-ID (diff)
From: Behan Webster <behanw@converseincode.com>
To: Mark Charlebois <charlebm@gmail.com>,
	Catalin Marinas <catalin.marinas@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Will Deacon <Will.Deacon@arm.com>,
	"zhichang.yuan@linaro.org" <zhichang.yuan@linaro.org>,
	"dsaxena@linaro.org" <dsaxena@linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: LLVMLinux: Provide __aeabi_* symbols which are needed for clang
Date: Mon, 08 Sep 2014 16:53:39 -0500	[thread overview]
Message-ID: <540E2563.8020909@converseincode.com> (raw)
In-Reply-To: <CAFzeTN10iz0eMTVqdRhzvqKagyB7srEZN8YAUOJzxzfJihv62Q@mail.gmail.com>

On 09/08/14 16:01, Mark Charlebois wrote:
> On Sun, Sep 7, 2014 at 12:30 AM, Catalin Marinas
> <catalin.marinas@arm.com> wrote:
>> On 7 Sep 2014, at 03:30, Mark Charlebois <charlebm@gmail.com> wrote:
>>> On Sat, Sep 6, 2014 at 7:16 AM, Arnd Bergmann <arnd@arndb.de> wrote:
>>>> On Friday 05 September 2014 16:23:14 behanw@converseincode.com wrote:
>>>>> + *  Copyright (C) 2012  Mark Charlebois
>>>>> + */
>>>>> +
>>>>> +/*
>>>>> + * EABI routines
>>>> Does EABI specify these function names? I would think that they are
>>>> just random libgcc (whatever that is called in clang) functions.
>>> http://infocenter.arm.com/help/topic/com.arm.doc.ihi0043d/IHI0043D_rtabi.pdf
>>>
>>> See section 4.3.4 Memory copying, clearing, and setting
>> What does this document have to do with arm64 (AArch64, A64)? We don’t
>> need such symbols on arm64. Also, the arm64 kernel links with libgcc (no
>> immediate need AFAICT but the compiler does not guarantee the intrinsics
>> would always be generated inline).
> [reposting in plain text]
>
> This patch was made early in the arm64 kernel support. I just retested
> and you are correct, it is no longer needed.  My apologies to all.

Whoops. I normally check whether a patch is still needed before posting 
them. I seem to have missed that step this time. My apologies as well.

That all being said, I prefer to see patches no longer required, than 
needing them to be upstreamed, so in that this is a win.

Behan

-- 
Behan Webster
behanw@converseincode.com


  reply	other threads:[~2014-09-08 21:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-05 23:23 [PATCH] arm64: LLVMLinux: Provide __aeabi_* symbols which are needed for clang behanw at converseincode.com
2014-09-05 23:23 ` behanw
2014-09-06 14:16 ` Arnd Bergmann
2014-09-06 14:16   ` Arnd Bergmann
2014-09-07  2:28   ` Behan Webster
2014-09-07  2:28     ` Behan Webster
2014-09-07  2:30   ` Mark Charlebois
2014-09-07  2:30     ` Mark Charlebois
2014-09-07  7:30     ` Catalin Marinas
2014-09-07  7:30       ` Catalin Marinas
2014-09-08 21:01       ` Mark Charlebois
2014-09-08 21:01         ` Mark Charlebois
2014-09-08 21:53         ` Behan Webster [this message]
2014-09-08 21:53           ` Behan Webster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540E2563.8020909@converseincode.com \
    --to=behanw@converseincode.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.