Re: [PATCH V4 4/5] xen, libxc: Request page fault injection via libxc

[Razvan Cojocaru <rcojocaru@bitdefender.com>]

On 09/09/2014 12:08 PM, Jan Beulich wrote:
>>>> On 08.09.14 at 18:21, <rcojocaru@bitdefender.com> wrote:
>> On 09/08/14 18:47, Jan Beulich wrote:
>>>>>> On 05.09.14 at 12:01, <rcojocaru@bitdefender.com> wrote:
>>>> +    {
>>>> +        hvm_inject_trap(&d->arch.hvm_domain.inject_trap);
>>>> +        d->arch.hvm_domain.inject_trap.vector = -1;
>>>> +    }
>>>
>>> And this is clearly lacking serialization (or a comment saying why
>>> serialization isn't needed here).
>>
>> If I understood this correctly, this is what Kevin has recommended: that
>> only one HVMOP_trap_request should be pending at a time. Or have I
>> misunderstood your comment?
> 
> Indeed you have - the comment is about dealing with races of e.g.
> two CPUs processing a request for trap injection at the same time.

Thanks for clearing that up. I hope I've addressed all these issues in
V6 (just posted), and hopefully patch 5/5 can also be Acked now (I'm now
using struct npfec as discussed).


Thanks,
Razvan Cojocaru