All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@tabi.org>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Shengjiu Wang <shengjiu.wang@freescale.com>,
	alsa-devel@alsa-project.org, tiwai@suse.de,
	linux-kernel@vger.kernel.org, broonie@kernel.org,
	lgirdwood@gmail.com, Li.Xiubo@freescale.com, mpa@pengutronix.de,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module
Date: Tue, 09 Sep 2014 15:37:26 -0500	[thread overview]
Message-ID: <540F6506.4060302@tabi.org> (raw)
In-Reply-To: <20140909202710.GB5224@Asurada>

On 09/09/2014 03:27 PM, Nicolin Chen wrote:
> I guess Mark's comment is merely against the check for clk validation
> because if talking about clk validation, we should check IS_ERR(clk)
> rather than check !=NULL directly.

Ah, that makes sense now.

> However, my approach doesn't need any check. The open() or pm_resume()
> can just call clk_prepare_enable() directly. The __clk_enable() will
> then handle the 'clk == NULL' case:

Yes, I was thinking the same thing.

WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@tabi.org>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Shengjiu Wang <shengjiu.wang@freescale.com>,
	alsa-devel@alsa-project.org, tiwai@suse.de,
	linux-kernel@vger.kernel.org, broonie@kernel.org,
	lgirdwood@gmail.com, perex@perex.cz, Li.Xiubo@freescale.com,
	mpa@pengutronix.de, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module
Date: Tue, 09 Sep 2014 15:37:26 -0500	[thread overview]
Message-ID: <540F6506.4060302@tabi.org> (raw)
In-Reply-To: <20140909202710.GB5224@Asurada>

On 09/09/2014 03:27 PM, Nicolin Chen wrote:
> I guess Mark's comment is merely against the check for clk validation
> because if talking about clk validation, we should check IS_ERR(clk)
> rather than check !=NULL directly.

Ah, that makes sense now.

> However, my approach doesn't need any check. The open() or pm_resume()
> can just call clk_prepare_enable() directly. The __clk_enable() will
> then handle the 'clk == NULL' case:

Yes, I was thinking the same thing.

WARNING: multiple messages have this Message-ID (diff)
From: Timur Tabi <timur@tabi.org>
To: Nicolin Chen <nicoleotsuka@gmail.com>
Cc: Shengjiu Wang <shengjiu.wang@freescale.com>,
	Li.Xiubo@freescale.com, lgirdwood@gmail.com, broonie@kernel.org,
	perex@perex.cz, tiwai@suse.de, alsa-devel@alsa-project.org,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	mpa@pengutronix.de
Subject: Re: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module
Date: Tue, 09 Sep 2014 15:37:26 -0500	[thread overview]
Message-ID: <540F6506.4060302@tabi.org> (raw)
In-Reply-To: <20140909202710.GB5224@Asurada>

On 09/09/2014 03:27 PM, Nicolin Chen wrote:
> I guess Mark's comment is merely against the check for clk validation
> because if talking about clk validation, we should check IS_ERR(clk)
> rather than check !=NULL directly.

Ah, that makes sense now.

> However, my approach doesn't need any check. The open() or pm_resume()
> can just call clk_prepare_enable() directly. The __clk_enable() will
> then handle the 'clk == NULL' case:

Yes, I was thinking the same thing.

  reply	other threads:[~2014-09-09 20:37 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09  9:18 [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module Shengjiu Wang
2014-09-09  9:18 ` Shengjiu Wang
2014-09-09  9:18 ` Shengjiu Wang
2014-09-09  9:49 ` [alsa-devel] " Markus Pargmann
2014-09-09  9:49   ` Markus Pargmann
2014-09-09  9:55 ` Li.Xiubo
2014-09-09  9:55   ` Li.Xiubo
2014-09-09 11:27 ` Mark Brown
2014-09-09 11:27   ` Mark Brown
2014-09-09 11:27   ` Mark Brown
2014-09-09 18:03   ` Nicolin Chen
2014-09-09 18:03     ` Nicolin Chen
2014-09-09 18:15     ` Mark Brown
2014-09-09 18:15       ` Mark Brown
2014-09-09 18:15       ` Mark Brown
2014-09-09 18:41       ` Nicolin Chen
2014-09-09 18:41         ` Nicolin Chen
2014-09-09 13:17 ` Timur Tabi
2014-09-09 15:21   ` Mark Brown
2014-09-09 15:21     ` Mark Brown
2014-09-09 15:24     ` Timur Tabi
2014-09-09 15:24       ` Timur Tabi
2014-09-09 15:24       ` Timur Tabi
2014-09-09 18:38 ` Nicolin Chen
2014-09-09 18:38   ` Nicolin Chen
2014-09-09 19:37   ` Timur Tabi
2014-09-09 19:37     ` Timur Tabi
2014-09-09 19:59     ` Nicolin Chen
2014-09-09 19:59       ` Nicolin Chen
2014-09-09 19:59       ` Nicolin Chen
2014-09-09 20:03       ` Timur Tabi
2014-09-09 20:03         ` Timur Tabi
2014-09-09 20:03         ` Timur Tabi
2014-09-09 20:27         ` Nicolin Chen
2014-09-09 20:27           ` Nicolin Chen
2014-09-09 20:37           ` Timur Tabi [this message]
2014-09-09 20:37             ` Timur Tabi
2014-09-09 20:37             ` Timur Tabi
2014-09-09 21:09             ` Nicolin Chen
2014-09-09 21:09               ` Nicolin Chen
2014-09-09 21:09               ` Nicolin Chen
2014-09-10 10:01       ` Shengjiu Wang
2014-09-10 10:01         ` Shengjiu Wang
2014-09-10 10:01         ` Shengjiu Wang
2014-09-10  6:21   ` Markus Pargmann
2014-09-10  6:21     ` Markus Pargmann
2014-09-10  6:42     ` [alsa-devel] " Nicolin Chen
2014-09-10  6:42       ` Nicolin Chen
2014-09-10 10:30     ` Shengjiu Wang
2014-09-10 10:30       ` Shengjiu Wang
2014-09-10 10:30       ` Shengjiu Wang
2014-09-10 10:53       ` Markus Pargmann
2014-09-10 10:53         ` Markus Pargmann
2014-09-10  8:12   ` Shengjiu Wang
2014-09-10  8:12     ` Shengjiu Wang
2014-09-10  8:12     ` Shengjiu Wang
2014-09-10 17:42     ` Nicolin Chen
2014-09-10 17:42       ` Nicolin Chen
2014-09-11  6:36       ` Markus Pargmann
2014-09-11  6:36         ` Markus Pargmann
2014-09-11  6:36         ` Markus Pargmann
2014-09-11  7:07         ` Shengjiu Wang
2014-09-11  7:07           ` Shengjiu Wang
2014-09-11  7:07           ` Shengjiu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540F6506.4060302@tabi.org \
    --to=timur@tabi.org \
    --cc=Li.Xiubo@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpa@pengutronix.de \
    --cc=nicoleotsuka@gmail.com \
    --cc=shengjiu.wang@freescale.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.