From: Richard Weinberger <richard@nod.at>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH] UBI: add missing kmem_cache_free() in process_pool_aeb error path
Date: Tue, 09 Sep 2014 23:43:55 +0200 [thread overview]
Message-ID: <540F749B.6080607@nod.at> (raw)
In-Reply-To: <1410265519-25111-1-git-send-email-richard.genoud@gmail.com>
Am 09.09.2014 14:25, schrieb Richard Genoud:
> I ran into this error after a ubiupdatevol, because I forgot to backport
> e9110361a9a4 UBI: fix the volumes tree sorting criteria.
>
> UBI error: process_pool_aeb: orphaned volume in fastmap pool
> UBI error: ubi_scan_fastmap: Attach by fastmap failed, doing a full scan!
> kmem_cache_destroy ubi_ainf_peb_slab: Slab cache still has objects
> CPU: 0 PID: 1 Comm: swapper Not tainted 3.14.18-00053-gf05cac8dbf85 #1
> [<c000d298>] (unwind_backtrace) from [<c000baa8>] (show_stack+0x10/0x14)
> [<c000baa8>] (show_stack) from [<c01b7a68>] (destroy_ai+0x230/0x244)
> [<c01b7a68>] (destroy_ai) from [<c01b8fd4>] (ubi_attach+0x98/0x1ec)
> [<c01b8fd4>] (ubi_attach) from [<c01ade90>] (ubi_attach_mtd_dev+0x2b8/0x868)
> [<c01ade90>] (ubi_attach_mtd_dev) from [<c038b510>] (ubi_init+0x1dc/0x2ac)
> [<c038b510>] (ubi_init) from [<c0008860>] (do_one_initcall+0x94/0x140)
> [<c0008860>] (do_one_initcall) from [<c037aadc>] (kernel_init_freeable+0xe8/0x1b0)
> [<c037aadc>] (kernel_init_freeable) from [<c02730ac>] (kernel_init+0x8/0xe4)
> [<c02730ac>] (kernel_init) from [<c00093f0>] (ret_from_fork+0x14/0x24)
> UBI: scanning is finished
>
> Freeing the cache in the error path fixes the Slab error.
>
> Tested on at91sam9g35 (3.14.18+fastmap backports)
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> Cc: stable <stable@vger.kernel.org> # >= 3.10
I guess you wrote 3.10 because there is no stable kernel between >= 3.7 and < 3.10?
Patch looks good otherwise.
Acked-by: Richard Weinberger <richard@nod.at>
Thanks,
//richard
WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: Artem Bityutskiy <dedekind1@gmail.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UBI: add missing kmem_cache_free() in process_pool_aeb error path
Date: Tue, 09 Sep 2014 23:43:55 +0200 [thread overview]
Message-ID: <540F749B.6080607@nod.at> (raw)
In-Reply-To: <1410265519-25111-1-git-send-email-richard.genoud@gmail.com>
Am 09.09.2014 14:25, schrieb Richard Genoud:
> I ran into this error after a ubiupdatevol, because I forgot to backport
> e9110361a9a4 UBI: fix the volumes tree sorting criteria.
>
> UBI error: process_pool_aeb: orphaned volume in fastmap pool
> UBI error: ubi_scan_fastmap: Attach by fastmap failed, doing a full scan!
> kmem_cache_destroy ubi_ainf_peb_slab: Slab cache still has objects
> CPU: 0 PID: 1 Comm: swapper Not tainted 3.14.18-00053-gf05cac8dbf85 #1
> [<c000d298>] (unwind_backtrace) from [<c000baa8>] (show_stack+0x10/0x14)
> [<c000baa8>] (show_stack) from [<c01b7a68>] (destroy_ai+0x230/0x244)
> [<c01b7a68>] (destroy_ai) from [<c01b8fd4>] (ubi_attach+0x98/0x1ec)
> [<c01b8fd4>] (ubi_attach) from [<c01ade90>] (ubi_attach_mtd_dev+0x2b8/0x868)
> [<c01ade90>] (ubi_attach_mtd_dev) from [<c038b510>] (ubi_init+0x1dc/0x2ac)
> [<c038b510>] (ubi_init) from [<c0008860>] (do_one_initcall+0x94/0x140)
> [<c0008860>] (do_one_initcall) from [<c037aadc>] (kernel_init_freeable+0xe8/0x1b0)
> [<c037aadc>] (kernel_init_freeable) from [<c02730ac>] (kernel_init+0x8/0xe4)
> [<c02730ac>] (kernel_init) from [<c00093f0>] (ret_from_fork+0x14/0x24)
> UBI: scanning is finished
>
> Freeing the cache in the error path fixes the Slab error.
>
> Tested on at91sam9g35 (3.14.18+fastmap backports)
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> Cc: stable <stable@vger.kernel.org> # >= 3.10
I guess you wrote 3.10 because there is no stable kernel between >= 3.7 and < 3.10?
Patch looks good otherwise.
Acked-by: Richard Weinberger <richard@nod.at>
Thanks,
//richard
next prev parent reply other threads:[~2014-09-09 21:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 12:25 [PATCH] UBI: add missing kmem_cache_free() in process_pool_aeb error path Richard Genoud
2014-09-09 12:25 ` Richard Genoud
2014-09-09 21:43 ` Richard Weinberger [this message]
2014-09-09 21:43 ` Richard Weinberger
2014-09-10 8:06 ` Richard Genoud
2014-09-10 8:06 ` Richard Genoud
2014-09-16 15:21 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540F749B.6080607@nod.at \
--to=richard@nod.at \
--cc=dedekind1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.