From: wahrenst@gmx.net (Stefan Wahren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 2/3] ARM: regulator: add Freescale MXS regulator driver
Date: Wed, 10 Sep 2014 19:24:09 +0200 [thread overview]
Message-ID: <54108939.5050208@gmx.net> (raw)
In-Reply-To: <20140910141853.GA4994@leverpostej>
Hi,
Am 10.09.2014 16:18, schrieb Mark Rutland:
>[...]
>
>>>> + of_property_read_u32(np, "mxs-default-microvolt",
>>>> + &val);
>>>> +
>>>> + if (val)
>>>> + mxs_set_voltage(rdev, val, val, NULL);
>>>
>>> As I mentioned in my comments on the binding, I'd like to know why this
>>> is necessary and if it is why it shouldn't be a standardised property.
>>
>> From my understanding the standardised properties only defines a range,
>> but no default state of the regulators. If the initialization from the
>> bootloader or a hardcoded initialization in the driver is okay then the
>> property is not necessary.
>
> Sure. My questions was why it is necessary to preconfigure the
> regulators at all rather than why it is necessary to do so in this
> manner.
>
> Mark.
>
sorry i don't have a clue. In the original code there isn't a comment
about the reason. Currently there is no init of the vddio regulator by
the kernel and everything works fine.
@Fabio: Do you have any doubts?
Stefan
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Wahren <wahrenst-hi6Y0CQ0nG0@public.gmane.org>
To: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: "lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
<lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <Pawel.Moll-5wv7dgnIgG8@public.gmane.org>,
"ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org"
<galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"stefan.wahren-eS4NqCHxEME@public.gmane.org"
<stefan.wahren-eS4NqCHxEME@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH RFC 2/3] ARM: regulator: add Freescale MXS regulator driver
Date: Wed, 10 Sep 2014 19:24:09 +0200 [thread overview]
Message-ID: <54108939.5050208@gmx.net> (raw)
In-Reply-To: <20140910141853.GA4994@leverpostej>
Hi,
Am 10.09.2014 16:18, schrieb Mark Rutland:
>[...]
>
>>>> + of_property_read_u32(np, "mxs-default-microvolt",
>>>> + &val);
>>>> +
>>>> + if (val)
>>>> + mxs_set_voltage(rdev, val, val, NULL);
>>>
>>> As I mentioned in my comments on the binding, I'd like to know why this
>>> is necessary and if it is why it shouldn't be a standardised property.
>>
>> From my understanding the standardised properties only defines a range,
>> but no default state of the regulators. If the initialization from the
>> bootloader or a hardcoded initialization in the driver is okay then the
>> property is not necessary.
>
> Sure. My questions was why it is necessary to preconfigure the
> regulators at all rather than why it is necessary to do so in this
> manner.
>
> Mark.
>
sorry i don't have a clue. In the original code there isn't a comment
about the reason. Currently there is no init of the vddio regulator by
the kernel and everything works fine.
@Fabio: Do you have any doubts?
Stefan
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Wahren <wahrenst@gmx.net>
To: Mark Rutland <mark.rutland@arm.com>,
"festevam@gmail.com" <festevam@gmail.com>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Pawel Moll <Pawel.Moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"stefan.wahren@i2se.com" <stefan.wahren@i2se.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RFC 2/3] ARM: regulator: add Freescale MXS regulator driver
Date: Wed, 10 Sep 2014 19:24:09 +0200 [thread overview]
Message-ID: <54108939.5050208@gmx.net> (raw)
In-Reply-To: <20140910141853.GA4994@leverpostej>
Hi,
Am 10.09.2014 16:18, schrieb Mark Rutland:
>[...]
>
>>>> + of_property_read_u32(np, "mxs-default-microvolt",
>>>> + &val);
>>>> +
>>>> + if (val)
>>>> + mxs_set_voltage(rdev, val, val, NULL);
>>>
>>> As I mentioned in my comments on the binding, I'd like to know why this
>>> is necessary and if it is why it shouldn't be a standardised property.
>>
>> From my understanding the standardised properties only defines a range,
>> but no default state of the regulators. If the initialization from the
>> bootloader or a hardcoded initialization in the driver is okay then the
>> property is not necessary.
>
> Sure. My questions was why it is necessary to preconfigure the
> regulators at all rather than why it is necessary to do so in this
> manner.
>
> Mark.
>
sorry i don't have a clue. In the original code there isn't a comment
about the reason. Currently there is no init of the vddio regulator by
the kernel and everything works fine.
@Fabio: Do you have any doubts?
Stefan
next prev parent reply other threads:[~2014-09-10 17:24 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-07 11:37 [PATCH RFC 0/3] ARM: regulator: add Freescale MXS regulator driver Stefan Wahren
2014-09-07 11:37 ` Stefan Wahren
2014-09-07 11:37 ` Stefan Wahren
2014-09-07 11:37 ` [PATCH RFC 1/3] DT: add binding for MXS regulator Stefan Wahren
2014-09-07 11:37 ` Stefan Wahren
2014-09-07 11:37 ` Stefan Wahren
2014-09-07 13:35 ` Sergei Shtylyov
2014-09-07 13:35 ` Sergei Shtylyov
2014-09-09 17:59 ` Mark Rutland
2014-09-09 17:59 ` Mark Rutland
2014-09-09 18:48 ` Stefan Wahren
2014-09-09 18:48 ` Stefan Wahren
2014-09-09 18:48 ` Stefan Wahren
2014-09-07 11:37 ` [PATCH RFC 2/3] ARM: regulator: add Freescale MXS regulator driver Stefan Wahren
2014-09-07 11:37 ` Stefan Wahren
2014-09-07 11:37 ` Stefan Wahren
2014-09-09 18:22 ` Mark Rutland
2014-09-09 18:22 ` Mark Rutland
2014-09-09 18:22 ` Mark Rutland
2014-09-09 19:17 ` Stefan Wahren
2014-09-09 19:17 ` Stefan Wahren
2014-09-10 14:18 ` Mark Rutland
2014-09-10 14:18 ` Mark Rutland
2014-09-10 14:18 ` Mark Rutland
2014-09-10 15:13 ` Mark Brown
2014-09-10 15:13 ` Mark Brown
2014-09-10 17:32 ` Stefan Wahren
2014-09-10 17:32 ` Stefan Wahren
2014-09-10 18:54 ` Fabio Estevam
2014-09-10 18:54 ` Fabio Estevam
2014-09-11 5:53 ` Stefan Wahren
2014-09-11 5:53 ` Stefan Wahren
2014-09-11 5:53 ` Stefan Wahren
2014-09-10 19:50 ` Mark Brown
2014-09-10 19:50 ` Mark Brown
2014-09-10 19:50 ` Mark Brown
2014-09-10 17:24 ` Stefan Wahren [this message]
2014-09-10 17:24 ` Stefan Wahren
2014-09-10 17:24 ` Stefan Wahren
2014-09-10 17:06 ` Fabio Estevam
2014-09-10 17:06 ` Fabio Estevam
2014-09-10 17:06 ` Fabio Estevam
2014-09-07 11:37 ` [PATCH RFC 3/3] DT: ARM: mxs: enable regulator support for i.MX28 Stefan Wahren
2014-09-07 11:37 ` Stefan Wahren
2014-09-07 11:37 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54108939.5050208@gmx.net \
--to=wahrenst@gmx.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.