From: Stephen Boyd <sboyd@codeaurora.org>
To: Will Deacon <will.deacon@arm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Rob Clark <robdclark@gmail.com>
Subject: Re: [PATCH] ARM: perf: Don't sleep while atomic when enabling per-cpu interrupts
Date: Wed, 10 Sep 2014 11:51:21 -0700 [thread overview]
Message-ID: <54109DA9.4070208@codeaurora.org> (raw)
In-Reply-To: <20140910182137.GL1710@arm.com>
On 09/10/14 11:21, Will Deacon wrote:
> On Tue, Sep 09, 2014 at 06:54:45PM +0100, Stephen Boyd wrote:
>
>> Here's the interdiff. Is there a reason arm64 casts data to an unsigned
>> int pointer when what's passed is an int pointer?
> There has to be a cast to something because data is a void *.
> enable_percpu_irq takes an unsigned int, so I guess that's why it was
> chosen. I'm not fussed either way.
Right, I'm just annoyed that what's passed in the void * is not an
unsigned int, it's an int. I agree that eventually we'll hand it to
enable_percpu_irq and there it will be implicitly casted to an unsigned
int so it really doesn't matter.
>
> Feel free to submit the full patch with my ack:
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
Ok thanks.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: perf: Don't sleep while atomic when enabling per-cpu interrupts
Date: Wed, 10 Sep 2014 11:51:21 -0700 [thread overview]
Message-ID: <54109DA9.4070208@codeaurora.org> (raw)
In-Reply-To: <20140910182137.GL1710@arm.com>
On 09/10/14 11:21, Will Deacon wrote:
> On Tue, Sep 09, 2014 at 06:54:45PM +0100, Stephen Boyd wrote:
>
>> Here's the interdiff. Is there a reason arm64 casts data to an unsigned
>> int pointer when what's passed is an int pointer?
> There has to be a cast to something because data is a void *.
> enable_percpu_irq takes an unsigned int, so I guess that's why it was
> chosen. I'm not fussed either way.
Right, I'm just annoyed that what's passed in the void * is not an
unsigned int, it's an int. I agree that eventually we'll hand it to
enable_percpu_irq and there it will be implicitly casted to an unsigned
int so it really doesn't matter.
>
> Feel free to submit the full patch with my ack:
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
Ok thanks.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-09-10 18:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 18:26 [PATCH] ARM: perf: Don't sleep while atomic when enabling per-cpu interrupts Stephen Boyd
2014-09-08 18:26 ` Stephen Boyd
2014-09-09 11:39 ` Will Deacon
2014-09-09 11:39 ` Will Deacon
2014-09-09 17:54 ` Stephen Boyd
2014-09-09 17:54 ` Stephen Boyd
2014-09-10 18:21 ` Will Deacon
2014-09-10 18:21 ` Will Deacon
2014-09-10 18:51 ` Stephen Boyd [this message]
2014-09-10 18:51 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54109DA9.4070208@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.