All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 4/5] gfs2: Don't use MAXQUOTAS value
Date: Thu, 11 Sep 2014 13:41:08 +0100	[thread overview]
Message-ID: <54119864.8080209@redhat.com> (raw)
In-Reply-To: <1410376972-18417-5-git-send-email-jack@suse.cz>

Hi,

On 10/09/14 20:22, Jan Kara wrote:
> MAXQUOTAS value defines maximum number of quota types VFS supports.
> This isn't necessarily the number of types gfs2 supports and with
> addition of project quotas these two numbers stop matching. So make gfs2
> use its private definition.
Now in the GFS2 -nmw tree. Thanks,

Steve.

> CC: Steven Whitehouse <swhiteho@redhat.com>
> CC: cluster-devel at redhat.com
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
>   fs/gfs2/incore.h | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
> index 67d310c9ada3..39e7e9959b74 100644
> --- a/fs/gfs2/incore.h
> +++ b/fs/gfs2/incore.h
> @@ -262,6 +262,9 @@ struct gfs2_holder {
>   	unsigned long gh_ip;
>   };
>   
> +/* Number of quota types we support */
> +#define GFS2_MAXQUOTAS 2
> +
>   /* Resource group multi-block reservation, in order of appearance:
>   
>      Step 1. Function prepares to write, allocates a mb, sets the size hint.
> @@ -282,8 +285,8 @@ struct gfs2_blkreserv {
>   	u64 rs_inum;                  /* Inode number for reservation */
>   
>   	/* ancillary quota stuff */
> -	struct gfs2_quota_data *rs_qa_qd[2 * MAXQUOTAS];
> -	struct gfs2_holder rs_qa_qd_ghs[2 * MAXQUOTAS];
> +	struct gfs2_quota_data *rs_qa_qd[2 * GFS2_MAXQUOTAS];
> +	struct gfs2_holder rs_qa_qd_ghs[2 * GFS2_MAXQUOTAS];
>   	unsigned int rs_qa_qd_num;
>   };
>   



WARNING: multiple messages have this Message-ID (diff)
From: Steven Whitehouse <swhiteho@redhat.com>
To: Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org
Cc: cluster-devel@redhat.com
Subject: Re: [PATCH 4/5] gfs2: Don't use MAXQUOTAS value
Date: Thu, 11 Sep 2014 13:41:08 +0100	[thread overview]
Message-ID: <54119864.8080209@redhat.com> (raw)
In-Reply-To: <1410376972-18417-5-git-send-email-jack@suse.cz>

Hi,

On 10/09/14 20:22, Jan Kara wrote:
> MAXQUOTAS value defines maximum number of quota types VFS supports.
> This isn't necessarily the number of types gfs2 supports and with
> addition of project quotas these two numbers stop matching. So make gfs2
> use its private definition.
Now in the GFS2 -nmw tree. Thanks,

Steve.

> CC: Steven Whitehouse <swhiteho@redhat.com>
> CC: cluster-devel@redhat.com
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
>   fs/gfs2/incore.h | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/incore.h b/fs/gfs2/incore.h
> index 67d310c9ada3..39e7e9959b74 100644
> --- a/fs/gfs2/incore.h
> +++ b/fs/gfs2/incore.h
> @@ -262,6 +262,9 @@ struct gfs2_holder {
>   	unsigned long gh_ip;
>   };
>   
> +/* Number of quota types we support */
> +#define GFS2_MAXQUOTAS 2
> +
>   /* Resource group multi-block reservation, in order of appearance:
>   
>      Step 1. Function prepares to write, allocates a mb, sets the size hint.
> @@ -282,8 +285,8 @@ struct gfs2_blkreserv {
>   	u64 rs_inum;                  /* Inode number for reservation */
>   
>   	/* ancillary quota stuff */
> -	struct gfs2_quota_data *rs_qa_qd[2 * MAXQUOTAS];
> -	struct gfs2_holder rs_qa_qd_ghs[2 * MAXQUOTAS];
> +	struct gfs2_quota_data *rs_qa_qd[2 * GFS2_MAXQUOTAS];
> +	struct gfs2_holder rs_qa_qd_ghs[2 * GFS2_MAXQUOTAS];
>   	unsigned int rs_qa_qd_num;
>   };
>   


  reply	other threads:[~2014-09-11 12:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-10 19:22 [PATCH 0/5] Remove MAXQUOTAS usage from filesystems Jan Kara
2014-09-10 19:22 ` [PATCH 1/5] ext3: Don't use MAXQUOTAS value Jan Kara
2014-09-10 19:22 ` [PATCH 2/5] ext4: " Jan Kara
2014-09-11 15:16   ` Theodore Ts'o
2014-09-10 19:22 ` [PATCH 3/5] reiserfs: " Jan Kara
2014-09-21 11:09   ` Jeff Mahoney
2014-09-10 19:22 ` [Cluster-devel] [PATCH 4/5] gfs2: " Jan Kara
2014-09-10 19:22   ` Jan Kara
2014-09-11 12:41   ` Steven Whitehouse [this message]
2014-09-11 12:41     ` Steven Whitehouse
2014-09-10 19:22 ` [Ocfs2-devel] [PATCH 5/5] ocfs2: " Jan Kara
2014-09-10 19:22   ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54119864.8080209@redhat.com \
    --to=swhiteho@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.