From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] dataplane: fix virtio_blk_data_plane_create() op blocker error path
Date: Thu, 11 Sep 2014 07:03:55 -0600 [thread overview]
Message-ID: <54119DBB.3080007@redhat.com> (raw)
In-Reply-To: <1410439779-20402-1-git-send-email-stefanha@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 664 bytes --]
On 09/11/2014 06:49 AM, Stefan Hajnoczi wrote:
> Commit 3718d8ab65f68de2acccbe6a315907805f54e3cc ("block: Replace in_use
> with operation blocker") broke the error path because it consumed
> local_err instead of propagating it.
>
> The caller has no way to know that the function failed. This caused
> virtio-blk to start "successfully" even though there was a fatal
> dataplane error.
>
> ---
> hw/block/dataplane/virtio-blk.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-09-11 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 12:49 [Qemu-devel] [PATCH] dataplane: fix virtio_blk_data_plane_create() op blocker error path Stefan Hajnoczi
2014-09-11 13:03 ` Eric Blake [this message]
2014-09-11 14:22 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54119DBB.3080007@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.