From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: berlin: fix the dt_free_map function
Date: Thu, 11 Sep 2014 23:04:43 +0200 [thread overview]
Message-ID: <54120E6B.4090704@gmail.com> (raw)
In-Reply-To: <1410340551-24023-1-git-send-email-antoine.tenart@free-electrons.com>
On 09/10/2014 11:15 AM, Antoine Tenart wrote:
> The berlin_pinctrl_dt_free_map function tries to free memory
> allocated and handled by the of subsystem. This is wrong and
> already handled by pinctrl_dt_free_maps() which calls
> of_node_put().
>
> This patch fixes the Berlin pinctrl way of freeing its maps,
> avoiding a kernel BUG(), by using the common
> pinctrl_utils_dt_free_map function instead.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> drivers/pinctrl/berlin/berlin.c | 21 +--------------------
> 1 file changed, 1 insertion(+), 20 deletions(-)
I like the diffstat :)
I am very short on time, so if it works for you, I am fine with it.
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Antoine Tenart <antoine.tenart@free-electrons.com>,
linus.walleij@linaro.org
Cc: alexandre.belloni@free-electrons.com,
thomas.petazzoni@free-electrons.com, zmxu@marvell.com,
jszhang@marvell.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: berlin: fix the dt_free_map function
Date: Thu, 11 Sep 2014 23:04:43 +0200 [thread overview]
Message-ID: <54120E6B.4090704@gmail.com> (raw)
In-Reply-To: <1410340551-24023-1-git-send-email-antoine.tenart@free-electrons.com>
On 09/10/2014 11:15 AM, Antoine Tenart wrote:
> The berlin_pinctrl_dt_free_map function tries to free memory
> allocated and handled by the of subsystem. This is wrong and
> already handled by pinctrl_dt_free_maps() which calls
> of_node_put().
>
> This patch fixes the Berlin pinctrl way of freeing its maps,
> avoiding a kernel BUG(), by using the common
> pinctrl_utils_dt_free_map function instead.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
> drivers/pinctrl/berlin/berlin.c | 21 +--------------------
> 1 file changed, 1 insertion(+), 20 deletions(-)
I like the diffstat :)
I am very short on time, so if it works for you, I am fine with it.
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Sebastian
next prev parent reply other threads:[~2014-09-11 21:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 9:15 [PATCH] pinctrl: berlin: fix the dt_free_map function Antoine Tenart
2014-09-10 9:15 ` Antoine Tenart
2014-09-11 21:04 ` Sebastian Hesselbarth [this message]
2014-09-11 21:04 ` Sebastian Hesselbarth
2014-09-23 15:02 ` Linus Walleij
2014-09-23 15:02 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54120E6B.4090704@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.