Re: [PATCH 2/3] mm: introduce VM_BUG_ON_MM

[Sasha Levin <sasha.levin@oracle.com>]

On 09/11/2014 05:16 PM, Andrew Morton wrote:
> On Sat,  6 Sep 2014 15:38:45 -0400 Sasha Levin <sasha.levin@oracle.com> wrote:
> 
>> Very similar to VM_BUG_ON_PAGE and VM_BUG_ON_VMA, dump struct_mm
>> when the bug is hit.
>>
>> ...
>>
>> +void dump_mm(const struct mm_struct *mm)
>> +{
>> +	printk(KERN_ALERT
> 
> I'm not sure why we should use KERN_ALERT here - KERN_EMERG is for
> "system is unusable", which is a fair descrition of a post-BUG kernel,
> yes?

Yes. I was following suit with dump_page and assumed there's a good reasoning
behind KERN_ALERT.

>> +		"mm %p mmap %p seqnum %d task_size %lu\n"
>> +#ifdef CONFIG_MMU
>> +		"get_unmapped_area %p\n"
>> +#endif
> 
> This printk is rather hilarious.  I can't think of a better way apart
> from a great string of individual printks.
> 
> And maybe we should use individual printks - dump_mm() presently uses
> 114 bytes of stack for that printk and that's somewhat of a concern
> considering the situations when it will be called.
> 
> 
> How's this look?

Works for me.


Thanks,
Sasha

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>