From: Larry Finger <Larry.Finger@lwfinger.net>
To: Kees Cook <keescook@chromium.org>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Greg KH <gregkh@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: repeated bugs in new rtl wifi drivers
Date: Thu, 11 Sep 2014 18:38:35 -0500 [thread overview]
Message-ID: <5412327B.6030000@lwfinger.net> (raw)
In-Reply-To: <CAGXu5j+kh3TTR8yiyH35mXUo91g5a-ULS6w2CvKzGmQ4UuL-aA@mail.gmail.com>
On 09/11/2014 05:27 PM, Kees Cook wrote:
> Hi,
>
> I keep fixing this same bug that keeps showing up in the rtl wifi
> drivers. CL_PRINTF keeps getting redefined (incorrectly) instead of
> using a correctly fixed global. Is there a way to stop this from
> happening again?
>
> Here are the past three (identical) fixes I've landed:
> a3355a62673e2c4bd8617d2f07c8edee92a89b8d
> 037526f1ae7eeff5cf27ad790ebfe30303eeebe8
> 6437f51ec36af8ef1e3e2659439b35c37e5498e2
>
> And the buildbot report below seems to show there are more to be made. :)
Sorry that I missed your fix. I should have seen it come through Linville's
list. I will push your fix through again.
We are in the process of unifying the in-house driver development at Realtek
with what I have been doing in the kernel. Unfortunately, this will involve
rather massive changes in all the codes. I am trying not to wipe out fixes such
as this one, but I expect that others will slip through. Once this painful
process is completed, maintaining the drivers should be a lot easier.
Larry
next prev parent reply other threads:[~2014-09-11 23:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 22:27 repeated bugs in new rtl wifi drivers Kees Cook
2014-09-11 22:37 ` Greg KH
2014-09-11 23:38 ` Larry Finger [this message]
2014-09-11 23:50 ` Kees Cook
2014-09-12 0:31 ` Larry Finger
2014-09-12 10:49 ` Masanari Iida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5412327B.6030000@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.