All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Richter <thor@math.tu-berlin.de>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>, stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Fix SRC_COPY width on 830/845g
Date: Fri, 12 Sep 2014 09:20:51 +0200	[thread overview]
Message-ID: <54129ED3.8060105@math.tu-berlin.de> (raw)
In-Reply-To: <23616_1410503880_541294C8_23616_19426_1_1410503862-29589-1-git-send-email-chris@chris-wilson.co.uk>

Am 12.09.2014 08:37, schrieb Chris Wilson:
> One small change I forgot to make in
>
> commit c4d69da167fa967749aeb70bc0e94a457e5d00c1
> Author: Chris Wilson <chris@chris-wilson.co.uk>
> Date:   Mon Sep 8 14:25:41 2014 +0100
>
>      drm/i915: Evict CS TLBs between batches
>
> was to update the copy width for the compact BLT copy instruction.
>
> Reported-by: Thomas Richter <thor@math.tu-berlin.de>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Thomas Richter <thor@math.tu-berlin.de>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: stable@vger.kernel.org
> ---
>   drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
> index d0156d6..45d70fd 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
> @@ -1386,7 +1386,7 @@ i830_emit_batchbuffer(struct i915_gem_request *rq,
>   		 */
>   		intel_ring_emit(ring, SRC_COPY_BLT_CMD | BLT_WRITE_RGBA);
>   		intel_ring_emit(ring, BLT_DEPTH_32 | BLT_ROP_SRC_COPY | 4096);
> -		intel_ring_emit(ring, DIV_ROUND_UP(len, 4096) << 16 | 1024);
> +		intel_ring_emit(ring, DIV_ROUND_UP(len, 4096) << 16 | 4096);
>   		intel_ring_emit(ring, cs_offset);
>   		intel_ring_emit(ring, 4096);
>   		intel_ring_emit(ring, offset);
Thanks Chris, this has done the trick! I get again a working display and 
a working GPU on my 830 machine.

Tested-by: Thomas Richter <thor@math.tu-berlin.de>

       reply	other threads:[~2014-09-12  7:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <23616_1410503880_541294C8_23616_19426_1_1410503862-29589-1-git-send-email-chris@chris-wilson.co.uk>
2014-09-12  7:20 ` Thomas Richter [this message]
2014-09-12  6:37 [PATCH] drm/i915: Fix SRC_COPY width on 830/845g Chris Wilson
2014-09-12  7:41 ` [Intel-gfx] " Jani Nikula
2014-09-12 15:06   ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54129ED3.8060105@math.tu-berlin.de \
    --to=thor@math.tu-berlin.de \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.