From: Jani Nikula <jani.nikula@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: Fix SRC_COPY width on 830/845g
Date: Fri, 12 Sep 2014 18:06:31 +0300 [thread overview]
Message-ID: <8761gsdgjs.fsf@intel.com> (raw)
In-Reply-To: <87egvhcmlv.fsf@intel.com>
On Fri, 12 Sep 2014, Jani Nikula <jani.nikula@intel.com> wrote:
> On Fri, 12 Sep 2014, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> One small change I forgot to make in
>>
>> commit c4d69da167fa967749aeb70bc0e94a457e5d00c1
>> Author: Chris Wilson <chris@chris-wilson.co.uk>
>> Date: Mon Sep 8 14:25:41 2014 +0100
>>
>> drm/i915: Evict CS TLBs between batches
>>
>> was to update the copy width for the compact BLT copy instruction.
>>
>> Reported-by: Thomas Richter <thor@math.tu-berlin.de>
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Thomas Richter <thor@math.tu-berlin.de>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: stable@vger.kernel.org
>
> http://mid.gmane.org/54129ED3.8060105@math.tu-berlin.de says
>
> Tested-by: Thomas Richter <thor@math.tu-berlin.de>
>
> (Thomas, your mails have broken in-reply-to/references more often than
> not, breaking threading. Please check your setup.)
Pushed to drm-intel-fixes with Daniel's irc ack, thanks for the patch
and testing.
BR,
Jani.
>
>
>> ---
>> drivers/gpu/drm/i915/intel_ringbuffer.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> index d0156d6..45d70fd 100644
>> --- a/drivers/gpu/drm/i915/intel_ringbuffer.c
>> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.c
>> @@ -1386,7 +1386,7 @@ i830_emit_batchbuffer(struct i915_gem_request *rq,
>> */
>> intel_ring_emit(ring, SRC_COPY_BLT_CMD | BLT_WRITE_RGBA);
>> intel_ring_emit(ring, BLT_DEPTH_32 | BLT_ROP_SRC_COPY | 4096);
>> - intel_ring_emit(ring, DIV_ROUND_UP(len, 4096) << 16 | 1024);
>> + intel_ring_emit(ring, DIV_ROUND_UP(len, 4096) << 16 | 4096);
>> intel_ring_emit(ring, cs_offset);
>> intel_ring_emit(ring, 4096);
>> intel_ring_emit(ring, offset);
>> --
>> 1.9.1
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Jani Nikula, Intel Open Source Technology Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2014-09-12 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 6:37 [PATCH] drm/i915: Fix SRC_COPY width on 830/845g Chris Wilson
2014-09-12 7:41 ` [Intel-gfx] " Jani Nikula
2014-09-12 15:06 ` Jani Nikula [this message]
[not found] <23616_1410503880_541294C8_23616_19426_1_1410503862-29589-1-git-send-email-chris@chris-wilson.co.uk>
2014-09-12 7:20 ` Thomas Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761gsdgjs.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.