From: Roger Quadros <rogerq@ti.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Brian Norris <computersforpeace@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>, pekon <pekon@pek-sem.com>,
linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 3/3] mtd: nand: Force omap_elm to be built as a module if omap2_nand is a module
Date: Fri, 12 Sep 2014 12:01:35 +0300 [thread overview]
Message-ID: <5412B66F.8050505@ti.com> (raw)
In-Reply-To: <1410443224-18477-4-git-send-email-ezequiel@vanguardiasur.com.ar>
On 09/11/2014 04:47 PM, Ezequiel Garcia wrote:
> This commit adds a hidden option to build the omap_elm as a module, if
> omap2_nand is a module (and similarly in the built-in case).
>
> This fixes the following build error when omap2_nand is chosen built-in,
> and omap_elm is chosen as a module:
>
> drivers/built-in.o: In function `omap_nand_probe':
> /work/linux-2.6/drivers/mtd/nand/omap2.c:2010: undefined reference to `elm_config'
> /work/linux-2.6/drivers/mtd/nand/omap2.c:1980: undefined reference to `elm_config'
> /work/linux-2.6/drivers/mtd/nand/omap2.c:1927: undefined reference to `elm_config'
> drivers/built-in.o: In function `omap_elm_correct_data':
> /work/linux-2.6/drivers/mtd/nand/omap2.c:1444: undefined reference to `elm_decode_bch_error_page'
>
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
> drivers/mtd/nand/Kconfig | 8 +++++++-
> drivers/mtd/nand/Makefile | 2 +-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index f1cf503..12e8ee8 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -96,7 +96,7 @@ config MTD_NAND_OMAP2
>
> config MTD_NAND_OMAP_BCH
> depends on MTD_NAND_OMAP2
> - tristate "Support hardware based BCH error correction"
> + bool "Support hardware based BCH error correction"
> default n
> select BCH
> help
> @@ -106,6 +106,12 @@ config MTD_NAND_OMAP_BCH
> legacy OMAP families like OMAP2xxx, OMAP3xxx do not have ELM engine
> so they should not enable this config symbol.
>
> +config MTD_NAND_OMAP_BCH_BUILD
> + tristate
> + depends on MTD_NAND_OMAP2
> + default m if MTD_NAND_OMAP2=m && MTD_NAND_OMAP_BCH
> + default y if MTD_NAND_OMAP2=y && MTD_NAND_OMAP_BCH
> +
> config MTD_NAND_IDS
> tristate
>
> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
> index 4bcdeb0..3580188 100644
> --- a/drivers/mtd/nand/Makefile
> +++ b/drivers/mtd/nand/Makefile
> @@ -27,7 +27,7 @@ obj-$(CONFIG_MTD_NAND_NDFC) += ndfc.o
> obj-$(CONFIG_MTD_NAND_ATMEL) += atmel_nand.o
> obj-$(CONFIG_MTD_NAND_GPIO) += gpio.o
> obj-$(CONFIG_MTD_NAND_OMAP2) += omap2_nand.o
> -obj-$(CONFIG_MTD_NAND_OMAP_BCH) += omap_elm.o
> +obj-$(CONFIG_MTD_NAND_OMAP_BCH_BUILD) += omap_elm.o
> obj-$(CONFIG_MTD_NAND_CM_X270) += cmx270_nand.o
> obj-$(CONFIG_MTD_NAND_PXA3xx) += pxa3xx_nand.o
> obj-$(CONFIG_MTD_NAND_TMIO) += tmio_nand.o
>
The overall logic seems to work but I still see the following issue.
In menuconfig, the OMAP_BCH option is still visible as a boolean even though
the ELM module finally gets built as a module.
This can be confusing to the user and I'd avoid that behaviour.
cheers,
-roger
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Brian Norris <computersforpeace@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org,
pekon <pekon@pek-sem.com>
Subject: Re: [PATCH 3/3] mtd: nand: Force omap_elm to be built as a module if omap2_nand is a module
Date: Fri, 12 Sep 2014 12:01:35 +0300 [thread overview]
Message-ID: <5412B66F.8050505@ti.com> (raw)
In-Reply-To: <1410443224-18477-4-git-send-email-ezequiel@vanguardiasur.com.ar>
On 09/11/2014 04:47 PM, Ezequiel Garcia wrote:
> This commit adds a hidden option to build the omap_elm as a module, if
> omap2_nand is a module (and similarly in the built-in case).
>
> This fixes the following build error when omap2_nand is chosen built-in,
> and omap_elm is chosen as a module:
>
> drivers/built-in.o: In function `omap_nand_probe':
> /work/linux-2.6/drivers/mtd/nand/omap2.c:2010: undefined reference to `elm_config'
> /work/linux-2.6/drivers/mtd/nand/omap2.c:1980: undefined reference to `elm_config'
> /work/linux-2.6/drivers/mtd/nand/omap2.c:1927: undefined reference to `elm_config'
> drivers/built-in.o: In function `omap_elm_correct_data':
> /work/linux-2.6/drivers/mtd/nand/omap2.c:1444: undefined reference to `elm_decode_bch_error_page'
>
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
> ---
> drivers/mtd/nand/Kconfig | 8 +++++++-
> drivers/mtd/nand/Makefile | 2 +-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index f1cf503..12e8ee8 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -96,7 +96,7 @@ config MTD_NAND_OMAP2
>
> config MTD_NAND_OMAP_BCH
> depends on MTD_NAND_OMAP2
> - tristate "Support hardware based BCH error correction"
> + bool "Support hardware based BCH error correction"
> default n
> select BCH
> help
> @@ -106,6 +106,12 @@ config MTD_NAND_OMAP_BCH
> legacy OMAP families like OMAP2xxx, OMAP3xxx do not have ELM engine
> so they should not enable this config symbol.
>
> +config MTD_NAND_OMAP_BCH_BUILD
> + tristate
> + depends on MTD_NAND_OMAP2
> + default m if MTD_NAND_OMAP2=m && MTD_NAND_OMAP_BCH
> + default y if MTD_NAND_OMAP2=y && MTD_NAND_OMAP_BCH
> +
> config MTD_NAND_IDS
> tristate
>
> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
> index 4bcdeb0..3580188 100644
> --- a/drivers/mtd/nand/Makefile
> +++ b/drivers/mtd/nand/Makefile
> @@ -27,7 +27,7 @@ obj-$(CONFIG_MTD_NAND_NDFC) += ndfc.o
> obj-$(CONFIG_MTD_NAND_ATMEL) += atmel_nand.o
> obj-$(CONFIG_MTD_NAND_GPIO) += gpio.o
> obj-$(CONFIG_MTD_NAND_OMAP2) += omap2_nand.o
> -obj-$(CONFIG_MTD_NAND_OMAP_BCH) += omap_elm.o
> +obj-$(CONFIG_MTD_NAND_OMAP_BCH_BUILD) += omap_elm.o
> obj-$(CONFIG_MTD_NAND_CM_X270) += cmx270_nand.o
> obj-$(CONFIG_MTD_NAND_PXA3xx) += pxa3xx_nand.o
> obj-$(CONFIG_MTD_NAND_TMIO) += tmio_nand.o
>
The overall logic seems to work but I still see the following issue.
In menuconfig, the OMAP_BCH option is still visible as a boolean even though
the ELM module finally gets built as a module.
This can be confusing to the user and I'd avoid that behaviour.
cheers,
-roger
next prev parent reply other threads:[~2014-09-12 9:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 13:47 [PATCH 0/3] nand: Renaming, moving and fixing NAND and ELM drivers Ezequiel Garcia
2014-09-11 13:47 ` [PATCH 1/3] mtd: nand: Move ELM driver and rename as omap_elm Ezequiel Garcia
2014-09-12 8:55 ` Roger Quadros
2014-09-11 13:47 ` [PATCH 2/3] mtd: nand: Rename OMAP NAND driver Ezequiel Garcia
2014-09-12 8:55 ` Roger Quadros
2014-09-11 13:47 ` [PATCH 3/3] mtd: nand: Force omap_elm to be built as a module if omap2_nand is a module Ezequiel Garcia
2014-09-12 9:01 ` Roger Quadros [this message]
2014-09-12 9:01 ` Roger Quadros
2014-09-12 16:56 ` Ezequiel Garcia
2014-09-12 16:56 ` Ezequiel Garcia
2014-09-15 8:27 ` Roger Quadros
2014-09-15 8:27 ` Roger Quadros
2014-09-18 3:00 ` Brian Norris
2014-09-18 3:00 ` Brian Norris
2014-09-18 8:40 ` Ezequiel Garcia
2014-09-18 8:40 ` Ezequiel Garcia
2014-09-18 8:42 ` Roger Quadros
2014-09-18 8:42 ` Roger Quadros
2014-09-18 8:40 ` Roger Quadros
2014-09-18 8:40 ` Roger Quadros
2014-09-22 19:04 ` Brian Norris
2014-09-22 19:04 ` Brian Norris
2014-09-12 8:54 ` [PATCH 0/3] nand: Renaming, moving and fixing NAND and ELM drivers Roger Quadros
2014-09-12 16:46 ` Ezequiel Garcia
2014-09-12 16:46 ` Ezequiel Garcia
2014-09-15 8:20 ` Roger Quadros
2014-09-15 8:20 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5412B66F.8050505@ti.com \
--to=rogerq@ti.com \
--cc=computersforpeace@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=pekon@pek-sem.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.