All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomas Henzl <thenzl@redhat.com>
To: "'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>
Cc: elliott@hp.com, steve.cameron@hp.com,
	Christoph Hellwig <hch@infradead.org>,
	"Handzik, Joe" <joseph.t.handzik@hp.com>
Subject: [PATCH] hpsa: add missing pci_set_master in kdump path
Date: Fri, 12 Sep 2014 14:44:15 +0200	[thread overview]
Message-ID: <5412EA9F.4060703@redhat.com> (raw)

Add a call to pci_set_master(...)  missing in the previous
patch "hpsa: refine the pci enable/disable handling".
Found thanks to Rob Elliot.
---
 drivers/scsi/hpsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 7828834..cef5d49 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -6544,7 +6544,7 @@ static int hpsa_init_reset_devices(struct pci_dev *pdev)
 		dev_warn(&pdev->dev, "failed to enable device.\n");
 		return -ENODEV;
 	}
-
+	pci_set_master(pdev);
 	/* Reset the controller with a PCI power-cycle or via doorbell */
 	rc = hpsa_kdump_hard_reset_controller(pdev);
 
-- 
1.8.3.1



             reply	other threads:[~2014-09-12 12:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-12 12:44 Tomas Henzl [this message]
2014-09-24 10:31 ` [PATCH] hpsa: add missing pci_set_master in kdump path Tomas Henzl
2014-09-24 13:54   ` Christoph Hellwig
2014-09-24 13:59   ` Elliott, Robert (Server Storage)
2014-09-24 14:04     ` Christoph Hellwig
2014-09-25 12:20 ` Christoph Hellwig
2014-09-25 12:41   ` Tomas Henzl
2014-09-25 17:01 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5412EA9F.4060703@redhat.com \
    --to=thenzl@redhat.com \
    --cc=elliott@hp.com \
    --cc=hch@infradead.org \
    --cc=joseph.t.handzik@hp.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=steve.cameron@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.