From: Tomas Henzl <thenzl@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "'linux-scsi@vger.kernel.org'" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] hpsa: add missing pci_set_master in kdump path
Date: Thu, 25 Sep 2014 14:41:07 +0200 [thread overview]
Message-ID: <54240D63.7080900@redhat.com> (raw)
In-Reply-To: <20140925122039.GA11116@infradead.org>
On 09/25/2014 02:20 PM, Christoph Hellwig wrote:
> Tomas, can you also give me a signed-off-by for this one?
Oh, I forgot to add it before.
Patch is
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
>
> On Fri, Sep 12, 2014 at 02:44:15PM +0200, Tomas Henzl wrote:
>> Add a call to pci_set_master(...) missing in the previous
>> patch "hpsa: refine the pci enable/disable handling".
>> Found thanks to Rob Elliot.
>> ---
>> drivers/scsi/hpsa.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
>> index 7828834..cef5d49 100644
>> --- a/drivers/scsi/hpsa.c
>> +++ b/drivers/scsi/hpsa.c
>> @@ -6544,7 +6544,7 @@ static int hpsa_init_reset_devices(struct pci_dev *pdev)
>> dev_warn(&pdev->dev, "failed to enable device.\n");
>> return -ENODEV;
>> }
>> -
>> + pci_set_master(pdev);
>> /* Reset the controller with a PCI power-cycle or via doorbell */
>> rc = hpsa_kdump_hard_reset_controller(pdev);
>>
>> --
>> 1.8.3.1
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> ---end quoted text---
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-25 12:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-12 12:44 [PATCH] hpsa: add missing pci_set_master in kdump path Tomas Henzl
2014-09-24 10:31 ` Tomas Henzl
2014-09-24 13:54 ` Christoph Hellwig
2014-09-24 13:59 ` Elliott, Robert (Server Storage)
2014-09-24 14:04 ` Christoph Hellwig
2014-09-25 12:20 ` Christoph Hellwig
2014-09-25 12:41 ` Tomas Henzl [this message]
2014-09-25 17:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54240D63.7080900@redhat.com \
--to=thenzl@redhat.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.