Re: [PATCH] arm64: dts: rockchip: Add uart dma names to the SoC dtsi for RK356x

From: Diederik de Haas <didi.debian@cknow.org>
To: linux-rockchip@lists.infradead.org,
	Philipp Puschmann <p.puschmann@pironex.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, p.puschmann@pironex.com,
	devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add uart dma names to the SoC dtsi for RK356x
Date: Wed, 10 Jul 2024 12:02:07 +0200	[thread overview]
Message-ID: <5414331.Y6POrrGVKo@bagend> (raw)
In-Reply-To: <20240710093356.3344056-1-p.puschmann@pironex.com>

[-- Attachment #1.1: Type: text/plain, Size: 1407 bytes --]

On Wednesday, 10 July 2024 11:33:56 CEST Philipp Puschmann wrote:
> DMA names are required by of_dma_request_slave_channel function that is
> called during uart probe. So to enable DMA for uarts add the names as in
> the RK3568 TRM.

Setting it on channels without flow control apparently causes issues. See

https://lore.kernel.org/linux-rockchip/20240628120130.24076-1-didi.debian@cknow.org/

> Signed-off-by: Philipp Puschmann <p.puschmann@pironex.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk356x.dtsi | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> b/arch/arm64/boot/dts/rockchip/rk356x.dtsi index d8543b5557ee..4ae40661ca6a
> 100644
> --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> @@ -489,6 +489,7 @@ uart0: serial@fdd50000 {
>  		clocks = <&pmucru SCLK_UART0>, <&pmucru PCLK_UART0>;
>  		clock-names = "baudclk", "apb_pclk";
>  		dmas = <&dmac0 0>, <&dmac0 1>;
> +		dma-names = "tx", "rx";
>  		pinctrl-0 = <&uart0_xfer>;
>  		pinctrl-names = "default";
>  		reg-io-width = <4>;
> @@ -1389,6 +1390,7 @@ uart1: serial@fe650000 {
>  		clocks = <&cru SCLK_UART1>, <&cru PCLK_UART1>;
>  		clock-names = "baudclk", "apb_pclk";
>  		dmas = <&dmac0 2>, <&dmac0 3>;
> +		dma-names = "tx", "rx";
>  		pinctrl-0 = <&uart1m0_xfer>;
>  		pinctrl-names = "default";
>  		reg-io-width = <4>;
> ...

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip